Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 231853003: Pepper: Remove Manifest::ResolveURL (Closed)

Created:
6 years, 8 months ago by teravest
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Remove Manifest::ResolveURL This need not be exposed as part of the Manifest interface. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263045

Patch Set 1 : #

Total comments: 1

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -70 lines) Patch
M ppapi/native_client/src/trusted/plugin/json_manifest.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/json_manifest.cc View 1 2 chunks +20 lines, -20 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/manifest.h View 2 chunks +1 line, -6 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 4 chunks +4 lines, -16 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_resources.h View 2 chunks +2 lines, -6 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_resources.cc View 2 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
teravest
6 years, 8 months ago (2014-04-10 16:19:54 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/231853003/diff/40001/ppapi/native_client/src/trusted/plugin/json_manifest.h File ppapi/native_client/src/trusted/plugin/json_manifest.h (right): https://codereview.chromium.org/231853003/diff/40001/ppapi/native_client/src/trusted/plugin/json_manifest.h#newcode77 ppapi/native_client/src/trusted/plugin/json_manifest.h:77: ErrorInfo* error_info) const; nit: This should probably also ...
6 years, 8 months ago (2014-04-10 16:48:01 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 8 months ago (2014-04-10 16:52:07 UTC) #3
teravest
On Thu, Apr 10, 2014 at 10:48 AM, <dmichael@chromium.org> wrote: > lgtm > > > ...
6 years, 8 months ago (2014-04-10 16:52:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/231853003/60001
6 years, 8 months ago (2014-04-10 16:52:39 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 19:18:25 UTC) #6
Message was sent while issue was closed.
Change committed as 263045

Powered by Google App Engine
This is Rietveld 408576698