experimental/webtry/templates/index.html - Issue 231853002: Cleaned up the start page, added wait cursor, disabled Run button while waiting for results.

Unified Diff: experimental/webtry/templates/index.html

Issue 231853002: Cleaned up the start page, added wait cursor, disabled Run button while waiting for results. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: experimental/webtry/templates/index.html

diff --git a/experimental/webtry/templates/index.html b/experimental/webtry/templates/index.html

index c630f14ef50c94854aa02b2065f401cbbfe177e8..00a245e067c6735e583e8d83fce3cb08ba54fc65 100644

--- a/experimental/webtry/templates/index.html

+++ b/experimental/webtry/templates/index.html

@@ -4,6 +4,9 @@

<title>Skia WebTry</title>

+ .waiting, .waiting * {

+ cursor: wait;

+ }

textarea {

margin-left: 0;

border: solid 1px #ccc;

@@ -20,20 +23,9 @@

</head>

<body>

<pre><code>#include "SkCanvas.h"

-#include "SkGraphics.h"

-#include "SkImageEncoder.h"

-#include "SkImageInfo.h"

-#include "SkForceLinking.h"

-int main() {

- SkForceLinking(false);

- SkGraphics::Init();

- SkImageInfo info = SkImageInfo::MakeN32(300, 300, kPremul_SkAlphaType);

mtklein 2014/04/09 21:00:49 I kinda liked these hints about what might be need

jcgregorio 2014/04/09 21:09:26 What if I add a download button that wraps the use

mtklein 2014/04/09 21:12:04 Aw, I'm just being grumpy. However you like is go

- SkAutoTUnref<SkSurface> surface(SkSurface::NewRaster(info));

- SkCanvas* canvas = surface->getCanvas();

- <textarea name='code' id='code' rows='20' cols='80'>SkPaint p;

+void draw(SkCanvas* canvas) {

+ <textarea name='code' id='code' rows='15' cols='80'>SkPaint p;

mtklein 2014/04/09 21:00:49 Why not 24? Heathen...

p.setColor(SK_ColorRED);

p.setAntiAlias(true);

p.setStyle(SkPaint::kStroke_Style);

@@ -41,10 +33,6 @@ p.setStrokeWidth(10);

canvas->drawLine(20, 20, 100, 100, p);

</textarea>

- if (!SkImageEncoder::EncodeFile("foo.png", bitmap, SkImageEncoder::kPNG_Type, 100)) {

- printf("Failed to encode\n");

- }

}

</code></pre>

@@ -61,6 +49,16 @@ canvas->drawLine(20, 20, 100, 100, p);

var output = document.getElementById('output');

var img = document.getElementById('img');

+ function beginWait() {

+ document.body.classList.add('waiting');

+ run.disabled = true;

+ }

+ function endWait() {

+ document.body.classList.remove('waiting');

+ run.disabled = false;

+ }

function codeComplete(e) {

// The response is JSON of the form:

// {

@@ -70,28 +68,31 @@ canvas->drawLine(20, 20, 100, 100, p);

// The img is optional and only appears if there is a valid

// image to display.

+ endWait();

console.log(e.target.response);

body = JSON.parse(e.target.response);

output.innerText = body.message;

if (body.hasOwnProperty('img')) {

- img.src = 'data:image/png;base64,' + body.img;

+ img.src = 'data:image/png;base64,' + body.img;

} else {

- img.src = '';

+ img.src = '';

}

function codeError(e) {

+ endWait();

alert('Something bad happened: ' + e);

}

run.addEventListener('click', onSubmitCode);

function onSubmitCode() {

- var req = new XMLHttpRequest();

- req.addEventListener('load', codeComplete);

- req.addEventListener('error', codeError);

- req.overrideMimeType('application/json');

- req.open('POST', '.', true);

- req.send(code.value);

+ beginWait();

+ var req = new XMLHttpRequest();

+ req.addEventListener('load', codeComplete);

+ req.addEventListener('error', codeError);

+ req.overrideMimeType('application/json');

+ req.open('POST', '.', true);

+ req.send(code.value);

}

</script>

</body>

« no previous file with comments | « no previous file | no next file » | no next file with comments »