Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 231853002: Cleaned up the start page, added wait cursor, disabled Run button while waiting for results. (Closed)

Created:
6 years, 8 months ago by jcgregorio
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Cleaned up the start page, added wait cursor, disabled Run button while waiting for results. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14121

Patch Set 1 #

Total comments: 4

Patch Set 2 : First pass as workspaces #

Patch Set 3 : first pass at workspaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -55 lines) Patch
M experimental/webtry/DESIGN.md View 1 3 chunks +52 lines, -31 lines 0 comments Download
M experimental/webtry/templates/index.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M experimental/webtry/templates/recent.html View 1 1 chunk +10 lines, -8 lines 0 comments Download
A + experimental/webtry/templates/workspace.html View 1 4 chunks +41 lines, -7 lines 0 comments Download
M experimental/webtry/webtry.go View 1 11 chunks +169 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jcgregorio
6 years, 8 months ago (2014-04-09 20:56:16 UTC) #1
mtklein
lgtm https://codereview.chromium.org/231853002/diff/1/experimental/webtry/templates/index.html File experimental/webtry/templates/index.html (left): https://codereview.chromium.org/231853002/diff/1/experimental/webtry/templates/index.html#oldcode32 experimental/webtry/templates/index.html:32: SkImageInfo info = SkImageInfo::MakeN32(300, 300, kPremul_SkAlphaType); I kinda ...
6 years, 8 months ago (2014-04-09 21:00:49 UTC) #2
jcgregorio
https://codereview.chromium.org/231853002/diff/1/experimental/webtry/templates/index.html File experimental/webtry/templates/index.html (left): https://codereview.chromium.org/231853002/diff/1/experimental/webtry/templates/index.html#oldcode32 experimental/webtry/templates/index.html:32: SkImageInfo info = SkImageInfo::MakeN32(300, 300, kPremul_SkAlphaType); What if I ...
6 years, 8 months ago (2014-04-09 21:09:25 UTC) #3
mtklein
https://codereview.chromium.org/231853002/diff/1/experimental/webtry/templates/index.html File experimental/webtry/templates/index.html (left): https://codereview.chromium.org/231853002/diff/1/experimental/webtry/templates/index.html#oldcode32 experimental/webtry/templates/index.html:32: SkImageInfo info = SkImageInfo::MakeN32(300, 300, kPremul_SkAlphaType); On 2014/04/09 21:09:26, ...
6 years, 8 months ago (2014-04-09 21:12:04 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-09 21:15:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/231853002/1
6 years, 8 months ago (2014-04-09 21:15:33 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 22:54:04 UTC) #7
Message was sent while issue was closed.
Change committed as 14121

Powered by Google App Engine
This is Rietveld 408576698