Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2318493002: Revert of Add buildbot metadata to compiler_proxy log (Closed)

Created:
4 years, 3 months ago by shinyak
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Add buildbot metadata to compiler_proxy log (patchset #5 id:80001 of https://codereview.chromium.org/2302453004/ ) Reason for revert: gsutil.py -h shows help. https://uberchromegw.corp.google.com/i/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/292446/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Add buildbot metadata to compiler_proxy log > > We'd like to analyze compiler proxy log. However, buildbot metadata is > missing, so sometimes hard to determine in which builder the compiler > proxy log is generated. > > Append buildbot metadata to compiler_proxy log like ninja log. > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/3d1cf68904cab7a23836940d3bdb1f43bee145b8 TBR=phajdan.jr@chromium.org,tikuta@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/tools/build/+/a6f720eeea8f1f50aba71d1d1c27024a406c6ffd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
M scripts/slave/compile.py View 1 chunk +1 line, -5 lines 0 comments Download
M scripts/slave/goma_utils.py View 5 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
shinyak
Created Revert of Add buildbot metadata to compiler_proxy log
4 years, 3 months ago (2016-09-06 07:14:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318493002/1
4 years, 3 months ago (2016-09-06 07:14:28 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 07:14:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/a6f720eeea8f1f50aba7...

Powered by Google App Engine
This is Rietveld 408576698