arc: Make ChromeVox read an ARC custom notification

ui/message_center/views/message_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/views/message_view.h"
 
+#include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/simple_menu_model.h"
 #include "ui/compositor/scoped_layer_animation_settings.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/shadow_value.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/message_center_style.h"
 #include "ui/message_center/views/message_center_controller.h"
 #include "ui/message_center/views/padded_button.h"
@@ skipping 36 matching lines @@
   views::ImageView* small_image_view = new views::ImageView();
   small_image_view->SetImage(notification.small_image().AsImageSkia());
   small_image_view->SetImageSize(gfx::Size(kSmallImageSize, kSmallImageSize));
   // The small image view should be added to view hierarchy by the derived
   // class. This ensures that it is on top of other views.
   small_image_view->set_owned_by_client();
   small_image_view_.reset(small_image_view);
 
   focus_painter_ = views::Painter::CreateSolidFocusPainter(
       kFocusBorderColor, gfx::Insets(0, 1, 3, 2));
+
+  accessible_name_ = CreateAccessibleName(notification);
 }
 
 MessageView::~MessageView() {
 }
 
 void MessageView::UpdateWithNotification(const Notification& notification) {
   small_image_view_->SetImage(notification.small_image().AsImageSkia());
   display_source_ = notification.display_source();
   CreateOrUpdateCloseButtonView(notification);
+  accessible_name_ = CreateAccessibleName(notification);
 }
 
 // static
 gfx::Insets MessageView::GetShadowInsets() {
   return gfx::Insets(kShadowBlur / 2 - kShadowOffset,
                      kShadowBlur / 2,
                      kShadowBlur / 2 + kShadowOffset,
                      kShadowBlur / 2);
 }
 
@@ skipping 171 matching lines @@
     close->SetAccessibleName(l10n_util::GetStringUTF16(
         IDS_MESSAGE_CENTER_CLOSE_NOTIFICATION_BUTTON_ACCESSIBLE_NAME));
     close->set_owned_by_client();
     AddChildView(close);
     close_button_.reset(close);
   } else if (notification.pinned() && close_button_) {
     close_button_.reset();
   }
 }
 
+base::string16 MessageView::CreateAccessibleName(

[yoshiki, 2016/09/07 08:29:34]

Could you make this method non-member of the MessageView and move it to the
anonymous namespace block (around l.35), since this doesn't touch any members?

[yhanada, 2016/09/07 08:52:26]

Done.

+    const Notification& notification) {
+  if (!notification.accessible_name().empty()) {

[yoshiki, 2016/09/07 08:29:34]

nit: no need of the braces for one line body.

[yhanada, 2016/09/07 08:52:26]

Done.

+    return notification.accessible_name();
+  }
+
+  // Fall back to a text constructed from the notification.
+  std::vector<base::string16> accessible_lines;
+  accessible_lines.push_back(notification.title());
+  accessible_lines.push_back(notification.message());
+  accessible_lines.push_back(notification.context_message());
+  std::vector<NotificationItem> items = notification.items();
+  for (size_t i = 0; i < items.size() && i < kNotificationMaximumItems; ++i) {
+    accessible_lines.push_back(items[i].title + base::ASCIIToUTF16(" ") +
+                               items[i].message);
+  }
+  return base::JoinString(accessible_lines, base::ASCIIToUTF16("\n"));
+}
+
 }  // namespace message_center