Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2318443002: service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts. (Closed)

Created:
4 years, 3 months ago by falken
Modified:
4 years, 3 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts. We're still not sure where the non-zero ref counts on shutdown come from. BUG=636377 Committed: https://crrev.com/e7ffbf80d3b612521a7c2564b21b96695586274a Cr-Commit-Position: refs/heads/master@{#416596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/browser/service_worker/service_worker_process_manager.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
falken
ptal
4 years, 3 months ago (2016-09-06 04:15:47 UTC) #2
horo
lgtm
4 years, 3 months ago (2016-09-06 05:17:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318443002/1
4 years, 3 months ago (2016-09-06 05:22:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 06:41:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e7ffbf80d3b612521a7c2564b21b96695586274a Cr-Commit-Position: refs/heads/master@{#416596}
4 years, 3 months ago (2016-09-06 06:42:30 UTC) #8
falken
4 years, 3 months ago (2016-09-08 07:28:57 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2320713003/ by falken@chromium.org.

The reason for reverting is: SWProcessManager is innocent. The CHECKs aren't
failing..

Powered by Google App Engine
This is Rietveld 408576698