Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 231843005: Extensions: Fix a bad dependency in _api_features.json. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
Reviewers:
mtomasz, benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Extensions: Fix a bad dependency in _api_features.json. The presubmit check is failing because of this. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/_api_features.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-10 08:28:35 UTC) #1
Lei Zhang
My CL is failing presubmit. You can see the error message in the presubmit try ...
6 years, 8 months ago (2014-04-10 08:32:54 UTC) #2
mtomasz
Thanks for fixing this. LGTM.
6 years, 8 months ago (2014-04-10 09:00:51 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-10 09:00:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/231843005/1
6 years, 8 months ago (2014-04-10 09:01:00 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 13:51:49 UTC) #6
Message was sent while issue was closed.
Change committed as 262974

Powered by Google App Engine
This is Rietveld 408576698