[Findit] Adding data model for capturing check flake analysis metadata

[Findit] Adding data model for capturing check flake analysis metadata

This change only adds the model and does not hook it up, which I plan to do in a separate CL once this change is approved in what is captured here.

BUG=644844
Committed: https://chromium.googlesource.com/infra/infra/+/6a2bffd95c58c986abb7cd50b05abe1df4914b9a

[lijeffrey, 2016-09-07 20:26:15]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, stgao@chromium.org

[lijeffrey, 2016-09-07 20:26:15]

ptal

[chanli, 2016-09-07 23:20:38]

Do you plan to make changes on FlakeSwarmingTask? For example, do you want to
add timestamps and task_id?

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
File appengine/findit/model/flake/master_flake_analysis_data.py (right):

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:10: class
FlakeSwarmingTaskData(ndb.Model):
Nit: how about CheckFlakeSwarmingTasksData?

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:12: # The UTC
timestamp the check flake task was requested UTC.
Nit: remove the 'UTC' at the end?

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:29: #     },s
nit: remove s?

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:36:
regression_build_numnber = ndb.IntegerProperty(indexed=None)
Nit: regression_build_number

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:36:
regression_build_numnber = ndb.IntegerProperty(indexed=None)
indexed=False?

[lijeffrey, 2016-09-08 13:49:58]

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
File appengine/findit/model/flake/master_flake_analysis_data.py (right):

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:10: class
FlakeSwarmingTaskData(ndb.Model):
On 2016/09/07 23:20:38, chanli wrote:
> Nit: how about CheckFlakeSwarmingTasksData?

How about CheckFlakeAnalysisData?

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:12: # The UTC
timestamp the check flake task was requested UTC.
On 2016/09/07 23:20:38, chanli wrote:
> Nit: remove the 'UTC' at the end?

Done.

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:29: #     },s
On 2016/09/07 23:20:38, chanli wrote:
> nit: remove s?

Done.

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:36:
regression_build_numnber = ndb.IntegerProperty(indexed=None)
On 2016/09/07 23:20:38, chanli wrote:
> indexed=False?

oops good catch!

https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
appengine/findit/model/flake/master_flake_analysis_data.py:36:
regression_build_numnber = ndb.IntegerProperty(indexed=None)
On 2016/09/07 23:20:38, chanli wrote:
> indexed=False?

Done.

[lijeffrey, 2016-09-08 13:51:05]

On 2016/09/07 23:20:38, chanli wrote:
> Do you plan to make changes on FlakeSwarmingTask? For example, do you want to
> add timestamps and task_id?
> 
>
https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
> File appengine/findit/model/flake/master_flake_analysis_data.py (right):
> 
>
https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
> appengine/findit/model/flake/master_flake_analysis_data.py:10: class
> FlakeSwarmingTaskData(ndb.Model):
> Nit: how about CheckFlakeSwarmingTasksData?
> 
>
https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
> appengine/findit/model/flake/master_flake_analysis_data.py:12: # The UTC
> timestamp the check flake task was requested UTC.
> Nit: remove the 'UTC' at the end?
> 
>
https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
> appengine/findit/model/flake/master_flake_analysis_data.py:29: #     },s
> nit: remove s?
> 
>
https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
> appengine/findit/model/flake/master_flake_analysis_data.py:36:
> regression_build_numnber = ndb.IntegerProperty(indexed=None)
> Nit: regression_build_number
> 
>
https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flak...
> appengine/findit/model/flake/master_flake_analysis_data.py:36:
> regression_build_numnber = ndb.IntegerProperty(indexed=None)
> indexed=False?

base_swarming_task should already have most of those, but no error dict so I
added that. I plan to hook up use of the error dict in a separate CL, this one's
just for making sure we have the right parts in the data model.

[lijeffrey, 2016-09-09 17:50:02]

ping..

[chanli, 2016-09-09 17:58:34]

On 2016/09/09 17:50:02, lijeffrey wrote:
> ping..

lgtm

[stgao, 2016-09-09 18:22:34]

lgtm with nits.

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
File appengine/findit/model/flake/master_flake_analysis_data.py (right):

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis_data.py:13: created_time =
ndb.DateTimeProperty(indexed=True)
Add empty lines in between.

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis_data.py:22: #        
'end_time': 2016-09-06 (10:21:26.288) UTC,
Shouldn't build number be captured too?

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis_data.py:52: def
_CreateCheckFlakeAnalysisDataId(
Merge into _CreateKey below?

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis_data.py:81: def
master_name(self):
Why not inherent BaseBuildModel to reduce these?

[lijeffrey, 2016-09-09 19:03:01]

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
File appengine/findit/model/flake/master_flake_analysis_data.py (right):

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis_data.py:13: created_time =
ndb.DateTimeProperty(indexed=True)
On 2016/09/09 18:22:34, stgao wrote:
> Add empty lines in between.

Done.

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis_data.py:22: #        
'end_time': 2016-09-06 (10:21:26.288) UTC,
On 2016/09/09 18:22:34, stgao wrote:
> Shouldn't build number be captured too?

good catch!

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis_data.py:52: def
_CreateCheckFlakeAnalysisDataId(
On 2016/09/09 18:22:34, stgao wrote:
> Merge into _CreateKey below?

Done.

https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/...
appengine/findit/model/flake/master_flake_analysis_data.py:81: def
master_name(self):
On 2016/09/09 18:22:34, stgao wrote:
> Why not inherent BaseBuildModel to reduce these?

Done.

[lijeffrey, 2016-09-09 19:03:07]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-09-09 19:03:07]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org,
stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2318363002/#ps60001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-09-09 19:03:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:17:26]

Description was changed from

==========
[Findit] Adding data model for capturing check flake analysis metadata

This change only adds the model and does not hook it up, which I plan to do in a
separate CL once this change is approved in what is captured here.

BUG=644844
==========

to

==========
[Findit] Adding data model for capturing check flake analysis metadata

This change only adds the model and does not hook it up, which I plan to do in a
separate CL once this change is approved in what is captured here.

BUG=644844

Committed:
https://chromium.googlesource.com/infra/infra/+/6a2bffd95c58c986abb7cd50b05ab...
==========

[commit-bot: I haz the power, 2016-09-09 19:17:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/6a2bffd95c58c986abb7cd50b05ab...