Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2318363002: [Findit] Adding data model for capturing check flake analysis metadata (Closed)

Created:
4 years, 3 months ago by lijeffrey
Modified:
4 years, 3 months ago
Reviewers:
chanli, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Adding data model for capturing check flake analysis metadata This change only adds the model and does not hook it up, which I plan to do in a separate CL once this change is approved in what is captured here. BUG=644844 Committed: https://chromium.googlesource.com/infra/infra/+/6a2bffd95c58c986abb7cd50b05abe1df4914b9a

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressing comments #

Patch Set 3 : Adding error dict to base_swarming_task #

Total comments: 8

Patch Set 4 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M appengine/findit/model/base_swarming_task.py View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
A appengine/findit/model/flake/master_flake_analysis_data.py View 1 2 3 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
lijeffrey
ptal
4 years, 3 months ago (2016-09-07 20:26:15 UTC) #2
chanli
Do you plan to make changes on FlakeSwarmingTask? For example, do you want to add ...
4 years, 3 months ago (2016-09-07 23:20:38 UTC) #3
lijeffrey
https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flake/master_flake_analysis_data.py File appengine/findit/model/flake/master_flake_analysis_data.py (right): https://codereview.chromium.org/2318363002/diff/1/appengine/findit/model/flake/master_flake_analysis_data.py#newcode10 appengine/findit/model/flake/master_flake_analysis_data.py:10: class FlakeSwarmingTaskData(ndb.Model): On 2016/09/07 23:20:38, chanli wrote: > Nit: ...
4 years, 3 months ago (2016-09-08 13:49:58 UTC) #4
lijeffrey
On 2016/09/07 23:20:38, chanli wrote: > Do you plan to make changes on FlakeSwarmingTask? For ...
4 years, 3 months ago (2016-09-08 13:51:05 UTC) #5
lijeffrey
ping..
4 years, 3 months ago (2016-09-09 17:50:02 UTC) #6
chanli
On 2016/09/09 17:50:02, lijeffrey wrote: > ping.. lgtm
4 years, 3 months ago (2016-09-09 17:58:34 UTC) #7
stgao
lgtm with nits. https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/flake/master_flake_analysis_data.py File appengine/findit/model/flake/master_flake_analysis_data.py (right): https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/flake/master_flake_analysis_data.py#newcode13 appengine/findit/model/flake/master_flake_analysis_data.py:13: created_time = ndb.DateTimeProperty(indexed=True) Add empty lines ...
4 years, 3 months ago (2016-09-09 18:22:34 UTC) #8
lijeffrey
https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/flake/master_flake_analysis_data.py File appengine/findit/model/flake/master_flake_analysis_data.py (right): https://codereview.chromium.org/2318363002/diff/40001/appengine/findit/model/flake/master_flake_analysis_data.py#newcode13 appengine/findit/model/flake/master_flake_analysis_data.py:13: created_time = ndb.DateTimeProperty(indexed=True) On 2016/09/09 18:22:34, stgao wrote: > ...
4 years, 3 months ago (2016-09-09 19:03:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318363002/60001
4 years, 3 months ago (2016-09-09 19:03:08 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 19:17:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/6a2bffd95c58c986abb7cd50b05ab...

Powered by Google App Engine
This is Rietveld 408576698