Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4281)

Unified Diff: chrome/browser/resources/md_history/synced_device_card.html

Issue 2318343004: MD History: Truncate long search terms in card title box (Closed)
Patch Set: truncate device name Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/shared_style.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/synced_device_card.html
diff --git a/chrome/browser/resources/md_history/synced_device_card.html b/chrome/browser/resources/md_history/synced_device_card.html
index 9fa197502c79e0ad4c47adfecc66ea0b07a07c05..c35e08ef220414df897e730e131beea364c7b671 100644
--- a/chrome/browser/resources/md_history/synced_device_card.html
+++ b/chrome/browser/resources/md_history/synced_device_card.html
@@ -28,10 +28,21 @@
padding: 8px 0;
}
+ #title-text {
+ overflow: hidden;
+ padding-right: 3px;
+ text-overflow: ellipsis;
+ }
+
#last-update-time {
color: var(--secondary-text-color);
}
+ #left-content {
tsergeant 2016/09/13 05:57:17 Nit: It might be good to name this something more
lshang 2016/09/13 23:50:28 Done.
+ display: flex;
+ overflow: hidden;
+ }
+
#right-buttons {
-webkit-margin-end: 4px;
}
@@ -67,8 +78,10 @@
<div id="history-item-container">
<div class="card-title" id="card-heading" aria-expanded$="[[opened]]"
aria-controls="collapse" on-tap="toggleTabCard">
- <div>
- [[device]]
+ <div id="left-content">
+ <div id="title-text">
+ [[device]]
+ </div>
lshang 2016/09/13 05:08:45 I moved "last-update-time" out of "title-text" so
<span id="last-update-time">[[lastUpdateTime]]</span>
</div>
<div id="right-buttons">
« no previous file with comments | « chrome/browser/resources/md_history/shared_style.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698