Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2318313003: Flesh out SkOpts namespaces. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Flesh out SkOpts namespaces. This makes it easier to see the baseline CPU feature settings for a build when looking at a stack trace or profile. This fills out all the features we currently might care about. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318313003 Committed: https://skia.googlesource.com/skia/+/da7136750d30f5f8a38808414e0f67f3382edacf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/core/SkOpts.cpp View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
mtklein_C
inspired by flutter
4 years, 3 months ago (2016-09-08 13:35:49 UTC) #6
bsalomon
lgtm
4 years, 3 months ago (2016-09-08 13:57:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318313003/1
4 years, 3 months ago (2016-09-08 13:58:50 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 13:59:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/da7136750d30f5f8a38808414e0f67f3382edacf

Powered by Google App Engine
This is Rietveld 408576698