Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2318313002: Add a NOTREACHED for same document load with no history item. (Closed)

Created:
4 years, 3 months ago by nasko
Modified:
4 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a NOTREACHED for same document load with no history item. BUG=635403 Committed: https://crrev.com/bebdfe3164e28e099388534bd89b2af2b28d69b4 Cr-Commit-Position: refs/heads/master@{#417045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
nasko
Hey Charlie, This is a CL for the NOTREACHED you wanted to have. Does it ...
4 years, 3 months ago (2016-09-07 19:33:37 UTC) #3
Charlie Reis
Thanks, LGTM. Let's land it tomorrow so it isn't in the same canary as r417012.
4 years, 3 months ago (2016-09-07 19:40:00 UTC) #6
nasko
On 2016/09/07 19:40:00, Charlie Reis wrote: > Thanks, LGTM. Let's land it tomorrow so it ...
4 years, 3 months ago (2016-09-07 19:46:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318313002/1
4 years, 3 months ago (2016-09-07 20:40:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:37:00 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:40:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bebdfe3164e28e099388534bd89b2af2b28d69b4
Cr-Commit-Position: refs/heads/master@{#417045}

Powered by Google App Engine
This is Rietveld 408576698