Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 2318303002: Remove stl_util's STLDeleteContainerPairSecondPointers. (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index eceffd9b95c3c91b7b0f3c340096877a3b163930..9979e7055496cabbbe79807a64fbe15d35956f40 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -14,9 +14,9 @@
#include "base/mac/mac_util.h"
#include "base/mac/sdk_forward_declarations.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/histogram_macros.h"
-#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -534,9 +534,7 @@ class AppControllerProfileObserver : public ProfileAttributesStorage::Observer {
appShimMenuController_.reset();
- base::STLDeleteContainerPairSecondPointers(
- profileBookmarkMenuBridgeMap_.begin(),
- profileBookmarkMenuBridgeMap_.end());
+ profileBookmarkMenuBridgeMap_.clear();
}
- (void)didEndMainMessageLoop {
@@ -883,11 +881,7 @@ class AppControllerProfileObserver : public ProfileAttributesStorage::Observer {
GetLastUsedProfile()];
}
- auto it = profileBookmarkMenuBridgeMap_.find(profilePath);
- if (it != profileBookmarkMenuBridgeMap_.end()) {
- delete it->second;
- profileBookmarkMenuBridgeMap_.erase(it);
- }
+ profileBookmarkMenuBridgeMap_.erase(profilePath);
}
// Returns true if there is a modal window (either window- or application-
@@ -1559,9 +1553,10 @@ class AppControllerProfileObserver : public ProfileAttributesStorage::Observer {
if (it == profileBookmarkMenuBridgeMap_.end()) {
base::scoped_nsobject<NSMenu> submenu([[bookmarkItem submenu] copy]);
bookmarkMenuBridge_ = new BookmarkMenuBridge(profile, submenu);
- profileBookmarkMenuBridgeMap_[profile->GetPath()] = bookmarkMenuBridge_;
+ profileBookmarkMenuBridgeMap_[profile->GetPath()] =
+ base::WrapUnique(bookmarkMenuBridge_);
} else {
- bookmarkMenuBridge_ = it->second;
+ bookmarkMenuBridge_ = it->second.get();
}
// No need to |BuildMenu| here. It is done lazily upon menu access.

Powered by Google App Engine
This is Rietveld 408576698