Remove stl_util's STLDeleteContainerPairSecondPointers.

Remove stl_util's STLDeleteContainerPairSecondPointers from all of Chromium.

BUG=555865
Committed: https://crrev.com/8255475b31183915dfc119cd97eb0b593c3b71a1
Cr-Commit-Position: refs/heads/master@{#420651}

[Avi (use Gerrit), 2016-09-07 19:18:46]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:35:29]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Avi (use Gerrit), 2016-09-07 20:19:46]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 20:20:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 20:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:36:09]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-09-07 21:51:57]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 21:52:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 22:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:06:55]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Avi (use Gerrit), 2016-09-07 22:19:28]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:19:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 22:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:37:53]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Avi (use Gerrit), 2016-09-21 19:59:31]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:59:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 20:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:40:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-09-21 20:42:45]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:43:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:34:50]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-09-22 15:35:16]

avi@chromium.org changed reviewers:
+ battre@chromium.org, thakis@chromium.org

[Avi (use Gerrit), 2016-09-22 15:35:17]

battre: syncable prefs
thakis: everything else

[Nico, 2016-09-22 15:56:12]

My stuff lgtm except for the two "walks twice" comments. And a whole bunch of
optional nits / suggestions.

https://codereview.chromium.org/2318303002/diff/100001/base/stl_util.h
File base/stl_util.h (left):

https://codereview.chromium.org/2318303002/diff/100001/base/stl_util.h#oldcode62
base/stl_util.h:62: }
The usual comment: I"d put this bit in a separate CL, so if some weird rare
config breaks due to the removal, only the removal gets reverted, not all the
rest of this CL here

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/browsin...
File chrome/browser/browsing_data/browsing_data_cookie_helper.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/browsin...
chrome/browser/browsing_data/browsing_data_cookie_helper.cc:164: return
origin_cookie_set_map_[first_party_origin].get();
This walks the tree twice. Either use insert() as on the lhs, or

  return (origin_cookie_set_map_[first_party_origin] =
    ase::MakeUnique<canonical_cookie::CookieHashSet>()).get();

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/command...
File chrome/browser/command_updater.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/command...
chrome/browser/command_updater.cc:64: for (auto it = commands_.begin(); it !=
commands_.end(); ++it) {
can't this be a for ( ... : commands_) style loop?

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/command...
chrome/browser/command_updater.cc:86: return commands_[id].get();
also walks twice

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/content...
File chrome/browser/content_settings/local_shared_objects_container.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/content...
chrome/browser/content_settings/local_shared_objects_container.cc:90: for (auto
cookie = cookie_list->begin(); cookie != cookie_list->end();
can this one be for-each?

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/notific...
File chrome/browser/notifications/message_center_notification_manager.cc (left):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/notific...
chrome/browser/notifications/message_center_notification_manager.cc:363: delete
profile_notification;
I found this one confusing. RemoveProfileNotification() doesn't take a
unique_ptr, so it doesn't look like it's going to take ownership of the pointer
– and in this function, it's now fairly hidden that the argument gets deleted.
Maybe RemoveFoo() methods where Foo is backed by a map<> should take the key of
the map, not the value? I.e. pass in the id here instead of the notification in
this case – I think that'd clean up all callers of this as well (at least the
ones I looked at).

(This is for extra brownie points; this code isn't worse after your CL than it
was before.)

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/password_store_mac.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/password_store_mac.cc:745: for (auto i =
matches.begin(); i != matches.end(); ++i) {
for-each?

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/password_store_mac.cc:880: for (auto i =
matches.begin() + 1; i != matches.end(); ++i) {
for-each?

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_syncable_service.cc (left):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:527: delete sync_item;
(this another instance of the map<key, value> that should maybe delete by key,
not value)

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_syncable_service.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:602: for (auto iter =
sync_items_.begin(); iter != sync_items_.end(); ++iter) {
for-each (?)

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:627: for (auto iter =
sync_items_.begin(); iter != sync_items_.end(); ++iter) {
same

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:630: for (auto iter =
sync_items_.begin(); iter != sync_items_.end();) {
same

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:665: for (auto iter =
sync_items_.begin(); iter != sync_items_.end(); ++iter) {
same

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:1013: for (auto iter =
sync_items_.begin(); iter != sync_items_.end(); ++iter) {
same (?)

[battre, 2016-09-22 16:44:24]

syncable prefs LGTM

https://codereview.chromium.org/2318303002/diff/100001/components/syncable_pr...
File components/syncable_prefs/pref_model_associator.h (right):

https://codereview.chromium.org/2318303002/diff/100001/components/syncable_pr...
components/syncable_prefs/pref_model_associator.h:192: // from sync.
I think that I would keep the typedef so that this comment makes sense here.

[Avi (use Gerrit), 2016-09-22 18:25:18]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairSecondPointers.

BUG=555865
==========

to

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from all of Chromium.

BUG=555865
==========

[Avi (use Gerrit), 2016-09-22 19:16:11]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-09-22 19:16:12]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
battre@chromium.org
Link to the patchset: https://codereview.chromium.org/2318303002/#ps120001
(title: "nits")

[commit-bot: I haz the power, 2016-09-22 19:16:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-22 19:17:18]

https://codereview.chromium.org/2318303002/diff/100001/base/stl_util.h
File base/stl_util.h (left):

https://codereview.chromium.org/2318303002/diff/100001/base/stl_util.h#oldcode62
base/stl_util.h:62: }
On 2016/09/22 15:56:11, Nico wrote:
> The usual comment: I"d put this bit in a separate CL, so if some weird rare
> config breaks due to the removal, only the removal gets reverted, not all the
> rest of this CL here

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/browsin...
File chrome/browser/browsing_data/browsing_data_cookie_helper.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/browsin...
chrome/browser/browsing_data/browsing_data_cookie_helper.cc:164: return
origin_cookie_set_map_[first_party_origin].get();
On 2016/09/22 15:56:11, Nico wrote:
> This walks the tree twice. Either use insert() as on the lhs, or
> 
>   return (origin_cookie_set_map_[first_party_origin] =
>     ase::MakeUnique<canonical_cookie::CookieHashSet>()).get();

I can't use insert, because Linux doesn't correctly handle it.

Rewriting.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/command...
File chrome/browser/command_updater.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/command...
chrome/browser/command_updater.cc:64: for (auto it = commands_.begin(); it !=
commands_.end(); ++it) {
On 2016/09/22 15:56:11, Nico wrote:
> can't this be a for ( ... : commands_) style loop?

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/command...
chrome/browser/command_updater.cc:86: return commands_[id].get();
On 2016/09/22 15:56:11, Nico wrote:
> also walks twice

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/content...
File chrome/browser/content_settings/local_shared_objects_container.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/content...
chrome/browser/content_settings/local_shared_objects_container.cc:90: for (auto
cookie = cookie_list->begin(); cookie != cookie_list->end();
On 2016/09/22 15:56:11, Nico wrote:
> can this one be for-each?

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/notific...
File chrome/browser/notifications/message_center_notification_manager.cc (left):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/notific...
chrome/browser/notifications/message_center_notification_manager.cc:363: delete
profile_notification;
On 2016/09/22 15:56:11, Nico wrote:
> I found this one confusing. RemoveProfileNotification() doesn't take a
> unique_ptr, so it doesn't look like it's going to take ownership of the
pointer
> –&nbsp;and in this function, it's now fairly hidden that the argument gets
deleted.
> Maybe RemoveFoo() methods where Foo is backed by a map<> should take the key
of
> the map, not the value? I.e. pass in the id here instead of the notification
in
> this case –&nbsp;I think that'd clean up all callers of this as well (at least
the
> ones I looked at).
> 
> (This is for extra brownie points; this code isn't worse after your CL than it
> was before.)

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/password_store_mac.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/password_store_mac.cc:745: for (auto i =
matches.begin(); i != matches.end(); ++i) {
On 2016/09/22 15:56:11, Nico wrote:
> for-each?

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/password_store_mac.cc:880: for (auto i =
matches.begin() + 1; i != matches.end(); ++i) {
On 2016/09/22 15:56:11, Nico wrote:
> for-each?

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_syncable_service.cc (left):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:527: delete sync_item;
On 2016/09/22 15:56:12, Nico wrote:
> (this another instance of the map<key, value> that should maybe delete by key,
> not value)

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_syncable_service.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:602: for (auto iter =
sync_items_.begin(); iter != sync_items_.end(); ++iter) {
On 2016/09/22 15:56:12, Nico wrote:
> for-each (?)

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:627: for (auto iter =
sync_items_.begin(); iter != sync_items_.end(); ++iter) {
On 2016/09/22 15:56:11, Nico wrote:
> same

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:630: for (auto iter =
sync_items_.begin(); iter != sync_items_.end();) {
On 2016/09/22 15:56:11, Nico wrote:
> same

Nope.

This loop deletes items (DeleteSyncItem) so we need to keep the iterator one
ahead so it doesn't become invalidated.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:665: for (auto iter =
sync_items_.begin(); iter != sync_items_.end(); ++iter) {
On 2016/09/22 15:56:12, Nico wrote:
> same

Done.

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_syncable_service.cc:1013: for (auto iter =
sync_items_.begin(); iter != sync_items_.end(); ++iter) {
On 2016/09/22 15:56:11, Nico wrote:
> same (?)

Done.

https://codereview.chromium.org/2318303002/diff/100001/components/syncable_pr...
File components/syncable_prefs/pref_model_associator.h (right):

https://codereview.chromium.org/2318303002/diff/100001/components/syncable_pr...
components/syncable_prefs/pref_model_associator.h:192: // from sync.
On 2016/09/22 16:44:24, battre wrote:
> I think that I would keep the typedef so that this comment makes sense here.

Fixed.

[commit-bot: I haz the power, 2016-09-22 19:19:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 19:19:38]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Avi (use Gerrit), 2016-09-22 19:37:14]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-09-22 19:37:15]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
battre@chromium.org
Link to the patchset: https://codereview.chromium.org/2318303002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-22 19:37:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 21:39:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 21:39:47]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-09-22 22:34:23]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-09-22 22:35:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:56:50]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2016-09-23 14:53:26]

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/password_store_mac.cc (right):

https://codereview.chromium.org/2318303002/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/password_store_mac.cc:880: for (auto i =
matches.begin() + 1; i != matches.end(); ++i) {
On 2016/09/22 19:17:17, Avi wrote:
> On 2016/09/22 15:56:11, Nico wrote:
> > for-each?
> 
> Done.

Nope; this is from +1 to end.

[Avi (use Gerrit), 2016-09-23 14:57:01]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-09-23 14:57:01]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
battre@chromium.org
Link to the patchset: https://codereview.chromium.org/2318303002/#ps160001
(title: "fix")

[commit-bot: I haz the power, 2016-09-23 14:57:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 15:10:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 15:10:44]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Avi (use Gerrit), 2016-09-23 16:02:40]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-09-23 16:03:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 17:49:11]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from all of Chromium.

BUG=555865
==========

to

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from all of Chromium.

BUG=555865
==========

[commit-bot: I haz the power, 2016-09-23 17:49:13]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-23 17:52:03]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from all of Chromium.

BUG=555865
==========

to

==========
Remove stl_util's STLDeleteContainerPairSecondPointers from all of Chromium.

BUG=555865

Committed: https://crrev.com/8255475b31183915dfc119cd97eb0b593c3b71a1
Cr-Commit-Position: refs/heads/master@{#420651}
==========

[commit-bot: I haz the power, 2016-09-23 17:52:04]

Patchset 9 (id:??) landed as
https://crrev.com/8255475b31183915dfc119cd97eb0b593c3b71a1
Cr-Commit-Position: refs/heads/master@{#420651}