[parser] Refactor of Parse*Statement*, part 3

[parser] Refactor of Parse*Statement*, part 3

This patch moves the following parsing methods to ParserBase:

- ParseScopedStatement
- ParseVariableStatement
- ParseDebuggerStatement
- ParseV8Intrinsic

It also cleans up the implementation-specific use counter mechanism.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/6874978c069c6630bedf13724491983e2d00bca1
Cr-Commit-Position: refs/heads/master@{#39272}

[nickie, 2016-09-07 18:47:56]

Description was changed from

==========
[parser] Refactor of Parse*Statement*, part 3

This patch moves the following parsing methods to ParserBase:

- ParseScopedStatement
- ParseVariableStatement
- ParseDebuggerStatement
- ParseV8Intrinsic

It also cleans up the implementation-specific use counter mechanism.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Refactor of Parse*Statement*, part 3

This patch moves the following parsing methods to ParserBase:

- ParseScopedStatement
- ParseVariableStatement
- ParseDebuggerStatement
- ParseV8Intrinsic

It also cleans up the implementation-specific use counter mechanism.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

[nickie, 2016-09-07 18:49:03]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 18:49:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:12:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:12:27]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-09-07 19:28:49]

lgtm except for one method name

https://codereview.chromium.org/2318263002/diff/20001/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2318263002/diff/20001/src/parsing/parser.h#ne...
src/parsing/parser.h:1023: V8_INLINE void
UseCounts(v8::Isolate::UseCounterFeature feature) {
Maybe "CountUsage()" instead?

[nickie, 2016-09-08 08:32:59]

https://codereview.chromium.org/2318263002/diff/20001/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2318263002/diff/20001/src/parsing/parser.h#ne...
src/parsing/parser.h:1023: V8_INLINE void
UseCounts(v8::Isolate::UseCounterFeature feature) {
On 2016/09/07 19:28:49, adamk wrote:
> Maybe "CountUsage()" instead?

Done.

[nickie, 2016-09-08 08:36:27]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 08:36:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 09:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 09:17:00]

Dry run: This issue passed the CQ dry run.

[marja, 2016-09-08 11:01:19]

lgtm

[nickie, 2016-09-08 11:02:05]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-09-08 11:02:05]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2318263002/#ps40001
(title: "Change after reviewers' comments")

[commit-bot: I haz the power, 2016-09-08 11:02:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 11:03:50]

Description was changed from

==========
[parser] Refactor of Parse*Statement*, part 3

This patch moves the following parsing methods to ParserBase:

- ParseScopedStatement
- ParseVariableStatement
- ParseDebuggerStatement
- ParseV8Intrinsic

It also cleans up the implementation-specific use counter mechanism.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Refactor of Parse*Statement*, part 3

This patch moves the following parsing methods to ParserBase:

- ParseScopedStatement
- ParseVariableStatement
- ParseDebuggerStatement
- ParseV8Intrinsic

It also cleans up the implementation-specific use counter mechanism.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

[commit-bot: I haz the power, 2016-09-08 11:03:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 11:04:33]

Description was changed from

==========
[parser] Refactor of Parse*Statement*, part 3

This patch moves the following parsing methods to ParserBase:

- ParseScopedStatement
- ParseVariableStatement
- ParseDebuggerStatement
- ParseV8Intrinsic

It also cleans up the implementation-specific use counter mechanism.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Refactor of Parse*Statement*, part 3

This patch moves the following parsing methods to ParserBase:

- ParseScopedStatement
- ParseVariableStatement
- ParseDebuggerStatement
- ParseV8Intrinsic

It also cleans up the implementation-specific use counter mechanism.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/6874978c069c6630bedf13724491983e2d00bca1
Cr-Commit-Position: refs/heads/master@{#39272}
==========

[commit-bot: I haz the power, 2016-09-08 11:04:34]

Patchset 3 (id:??) landed as
https://crrev.com/6874978c069c6630bedf13724491983e2d00bca1
Cr-Commit-Position: refs/heads/master@{#39272}