Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/content_settings/core/browser/content_settings_pref.h

Issue 2318223002: Remove EmptyRuleIterators with nullptrs. (Closed)
Patch Set: Fix failing unit test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc ('k') | components/content_settings/core/browser/content_settings_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/browser/content_settings_pref.h
diff --git a/components/content_settings/core/browser/content_settings_pref.h b/components/content_settings/core/browser/content_settings_pref.h
index 1a600d6c156242da7bd670a449341ee07fb7d76f..aa2ab178e3d9ea190b52cf71b723f7dafcf03f91 100644
--- a/components/content_settings/core/browser/content_settings_pref.h
+++ b/components/content_settings/core/browser/content_settings_pref.h
@@ -51,6 +51,7 @@ class ContentSettingsPref {
NotifyObserversCallback notify_callback);
~ContentSettingsPref();
+ // Returns nullptr to indicate the RuleIterator is empty.
std::unique_ptr<RuleIterator> GetRuleIterator(
const ResourceIdentifier& resource_identifier,
bool incognito) const;
« no previous file with comments | « components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc ('k') | components/content_settings/core/browser/content_settings_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698