chrome/browser/content_settings/content_settings_pref_provider_unittest.cc - Issue 2318223002: Remove EmptyRuleIterators with nullptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Issue 2318223002: Remove EmptyRuleIterators with nullptrs. (Closed)

Patch Set: Fix failing unit test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_policy_provider_unittest.cc ('k') | chrome/browser/extensions/api/content_settings/content_settings_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

index 5ee41e7b3e8f73a2d0ee7beb1b2cfa5bc8cb051b..f6cacd2e4e31dfaece9f4c2b88d7c361b72a69d1 100644

--- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

@@ -419,7 +419,7 @@ TEST_F(PrefProviderTest, IncognitoInheritsValueMap) {

{

std::unique_ptr<RuleIterator> it(normal_provider.GetRuleIterator(

CONTENT_SETTINGS_TYPE_COOKIES, std::string(), true));

- EXPECT_FALSE(it->HasNext());

+ EXPECT_FALSE(it);

}

// Create an incognito provider and set a setting.