Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 2318203002: [Android] Enable USB reset on perf bots. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index 9207ea83df13e86607fbbab003bea5641921a17f..4cc99a69481fec4a067e3aa701d327d60e9932bc 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -434,6 +434,8 @@ class AndroidApi(recipe_api.RecipeApi):
'--adb-path', self.m.adb.adb_path(),
'-v'
]
+ if restart_usb:
+ args += ['--enable-usb-reset']
self.m.step(
'device_recovery',
[self.m.path['checkout'].join('third_party', 'catapult', 'devil',
@@ -1046,7 +1048,9 @@ class AndroidApi(recipe_api.RecipeApi):
self.create_adb_symlink()
self.spawn_logcat_monitor()
self.authorize_adb_devices()
- self.device_recovery()
+ # TODO(jbudorick): Restart USB only on perf bots while we
+ # figure out the fate of the usb reset in general.
+ self.device_recovery(restart_usb=perf_setup)
if perf_setup:
kwargs = {
'min_battery_level': 95,
« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698