Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: src/apinatives.js

Issue 23182003: Push SetAccessor to Template (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« include/v8.h ('K') | « src/api.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 } 86 }
87 %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM); 87 %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM);
88 var parent = %GetTemplateField(data, kApiParentTemplateOffset); 88 var parent = %GetTemplateField(data, kApiParentTemplateOffset);
89 // Note: Do not directly use a function template as a condition, our 89 // Note: Do not directly use a function template as a condition, our
90 // internal ToBoolean doesn't handle that! 90 // internal ToBoolean doesn't handle that!
91 if (!(typeof parent === 'undefined')) { 91 if (!(typeof parent === 'undefined')) {
92 var parent_fun = Instantiate(parent); 92 var parent_fun = Instantiate(parent);
93 %SetPrototype(fun.prototype, parent_fun.prototype); 93 %SetPrototype(fun.prototype, parent_fun.prototype);
94 } 94 }
95 ConfigureTemplateInstance(fun, data); 95 ConfigureTemplateInstance(fun, data);
96 cache[serialNumber] = %ToFastProperties(fun);
Michael Starzinger 2013/08/20 17:05:41 It seems dangerous to re-set the cached value down
96 } catch (e) { 97 } catch (e) {
97 cache[serialNumber] = kUninitialized; 98 cache[serialNumber] = kUninitialized;
98 throw e; 99 throw e;
99 } 100 }
100 } 101 }
101 return cache[serialNumber]; 102 return cache[serialNumber];
102 } 103 }
103 104
104 105
105 function ConfigureTemplateInstance(obj, data) { 106 function ConfigureTemplateInstance(obj, data) {
106 var properties = %GetTemplateField(data, kApiPropertyListOffset); 107 var properties = %GetTemplateField(data, kApiPropertyListOffset);
107 if (properties) { 108 if (properties) {
108 // Disable access checks while instantiating the object. 109 // Disable access checks while instantiating the object.
109 var requires_access_checks = %DisableAccessChecks(obj); 110 var requires_access_checks = %DisableAccessChecks(obj);
110 try { 111 try {
111 for (var i = 0; i < properties[0]; i += 3) { 112 for (var i = 0; i < properties[0]; i += 3) {
112 var name = properties[i + 1]; 113 var name = properties[i + 1];
113 var prop_data = properties[i + 2]; 114 var prop_data = properties[i + 2];
114 var attributes = properties[i + 3]; 115 var attributes = properties[i + 3];
115 var value = Instantiate(prop_data, name); 116 var value = Instantiate(prop_data, name);
116 %SetProperty(obj, name, value, attributes); 117 %SetProperty(obj, name, value, attributes);
117 } 118 }
118 } finally { 119 } finally {
119 if (requires_access_checks) %EnableAccessChecks(obj); 120 if (requires_access_checks) %EnableAccessChecks(obj);
120 } 121 }
121 } 122 }
122 } 123 }
OLDNEW
« include/v8.h ('K') | « src/api.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698