Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2318183002: Revert of Make AALinearizingConvexPathRenderer able to handle stroke and fill (Closed)

Created:
4 years, 3 months ago by robertphillips
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make AALinearizingConvexPathRenderer able to handle stroke and fill (patchset #7 id:120001 of https://codereview.chromium.org/2301353004/ ) Reason for revert: Image quality issues on Android devices Original issue's description: > Make AALinearizingConvexPathRenderer able to handle stroke and fill > > This is intended to catch stroke-and-fill convex paths with potentially small stroke widths (e.g., .1). > > It does have the disconcerting side effect of changing bevel-joined stroke-and-filled degenerate-single-line-rects into plain rects (w/o triangular end-caps). > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301353004 > > Committed: https://skia.googlesource.com/skia/+/522bcd99fa65a8abd130880f59b500cf367d0845 TBR=ethannicholas@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/7a00e8bc9868f262d13d21c484f978f99e0adb95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -115 lines) Patch
M src/gpu/batches/GrAAConvexTessellator.h View 4 chunks +2 lines, -13 lines 0 comments Download
M src/gpu/batches/GrAAConvexTessellator.cpp View 8 chunks +14 lines, -64 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 7 chunks +8 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of Make AALinearizingConvexPathRenderer able to handle stroke and fill
4 years, 3 months ago (2016-09-07 15:28:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318183002/1
4 years, 3 months ago (2016-09-07 15:29:04 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 15:29:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7a00e8bc9868f262d13d21c484f978f99e0adb95

Powered by Google App Engine
This is Rietveld 408576698