Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2318133003: GN: fontmgr_custom (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
bungeman-skia, reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: fontmgr_custom This makes skia_use_fontconfig=false build on Linux. Instead of using fontconfig it looks in /usr/share/fonts. That alone is a nice feature to have, but it's mostly relevant for MSAN, where we can't link against any uninstrumented system libraries. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318133003 Committed: https://skia.googlesource.com/skia/+/d2e39dbc6a68a6cc2a480d0c8082eb204f6b6e77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
4 years, 3 months ago (2016-09-07 14:30:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318133003/1
4 years, 3 months ago (2016-09-07 14:30:21 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-07 14:30:22 UTC) #6
jcgregorio
lgtm
4 years, 3 months ago (2016-09-07 14:44:04 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 14:52:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d2e39dbc6a68a6cc2a480d0c8082eb204f6b6e77

Powered by Google App Engine
This is Rietveld 408576698