Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Issue 231813005: [chromedriver] Allow new privileges so that chrome's setuid sandbox can run (Closed)

Created:
6 years, 8 months ago by samuong
Modified:
6 years, 8 months ago
Reviewers:
stgao
CC:
chromium-reviews, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

When launching chrome, allow new privileges so that chrome's setuid sandbox can run properly. This was recently set to false by default, and is causing problems with the Linux64/Linux32 chromedriver waterfall. https://src.chromium.org/viewvc/chrome?revision=262786&view=revision BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
samuong
6 years, 8 months ago (2014-04-10 00:25:50 UTC) #1
stgao
lgtm
6 years, 8 months ago (2014-04-10 00:28:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/231813005/1
6 years, 8 months ago (2014-04-10 00:29:28 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 00:31:31 UTC) #4
Message was sent while issue was closed.
Change committed as 262877

Powered by Google App Engine
This is Rietveld 408576698