Improve GN public header file checking

Improve GN public header file checking

This makes the header checker and include iterator work from InputFiles (which basically just hold the file buffer) rather than just raw strings. This allows us to reference these files from Err.

Some extra line/char tracking is now in the include iterator so we can actually quote from and annotate the place in the source file where the bad include is, which looks much nicer than "the file blah included blah". It also makes it possible to write much shorter error messages that still make sense.

This adds visibility checking as previously documented in the help for "public" and a unit test for that.

This updates the documentation for "public" which was wrong (it referred to patterns which was not used).

R=scottmg@chromium.org
Reland of https://codereview.chromium.org/229423002/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263082

[brettw, 2014-04-09 20:37:44]

This is the only diff from the previous patch:
https://codereview.chromium.org/229423002/diff2/30001:40001/tools/gn/c_includ...

[scottmg, 2014-04-09 20:38:52]

diff lgtm

[scottmg, 2014-04-09 20:40:03]

(checked_cast would be more correct I guess, but doesn't matter much in
this code)


On Wed, Apr 9, 2014 at 1:38 PM, <scottmg@chromium.org> wrote:

> diff lgtm
>
> https://codereview.chromium.org/231813002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2014-04-10 21:13:20]

Committed patchset #1 manually as r263082 (presubmit successful).