Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: components/crash/content/browser/crash_handler_host_linux.cc

Issue 2318123002: Remove calls to IsRunningSequenceOnCurrentThread() from crash_handler_host_linux.cc (Closed)
Patch Set: fix build error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/content/browser/crash_handler_host_linux.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/browser/crash_handler_host_linux.cc
diff --git a/components/crash/content/browser/crash_handler_host_linux.cc b/components/crash/content/browser/crash_handler_host_linux.cc
index 8c9216ff132e10670f085842169d304b4e621192..7bb7c805192bf495519c952b86cb866e5342a63b 100644
--- a/components/crash/content/browser/crash_handler_host_linux.cc
+++ b/components/crash/content/browser/crash_handler_host_linux.cc
@@ -101,6 +101,8 @@ CrashHandlerHostLinux::CrashHandlerHostLinux(const std::string& process_type,
#endif
shutting_down_(false),
worker_pool_token_(base::SequencedWorkerPool::GetSequenceToken()) {
+ write_dump_file_sequence_checker_.DetachFromSequence();
+
int fds[2];
// We use SOCK_SEQPACKET rather than SOCK_DGRAM to prevent the process from
// sending datagrams to other sockets on the system. The sandbox may prevent
@@ -401,8 +403,7 @@ void CrashHandlerHostLinux::WriteDumpFile(std::unique_ptr<BreakpadInfo> info,
std::unique_ptr<char[]> crash_context,
pid_t crashing_pid,
int signal_fd) {
- DCHECK(BrowserThread::GetBlockingPool()->IsRunningSequenceOnCurrentThread(
- worker_pool_token_));
+ DCHECK(write_dump_file_sequence_checker_.CalledOnValidSequence());
// Set |info->distro| here because base::GetLinuxDistro() needs to run on a
// blocking thread.
« no previous file with comments | « components/crash/content/browser/crash_handler_host_linux.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698