Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2318123002: Remove calls to IsRunningSequenceOnCurrentThread() from crash_handler_host_linux.cc (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, jam, darin-cc_chromium.org, sadrul, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to IsRunningSequenceOnCurrentThread() from crash_handler_host_linux.cc SequencedWorkerPool is being migrated to base/task_scheduler and there is no equivalent to IsRunningSequenceOnCurrentThread() in base/task_scheduler. Developers should use SequenceChecker to verify that tasks run sequentially. Unlike SequencedWorkerPool::IsRunningSequenceOnCurrentThread(), SequenceChecker works everywhere in Chrome (MessageLoop, SequencedWorkerPool, base/task_scheduler...). BUG=622400 Committed: https://crrev.com/1b269e7e22c457144521ff7a34d2599d963502b5 Cr-Commit-Position: refs/heads/master@{#417388}

Patch Set 1 #

Patch Set 2 : fix test error #

Patch Set 3 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M components/crash/content/browser/crash_handler_host_linux.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/crash/content/browser/crash_handler_host_linux.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-08 16:22:20 UTC) #14
Robert Sesek
lgtm
4 years, 3 months ago (2016-09-08 20:22:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318123002/40001
4 years, 3 months ago (2016-09-08 20:33:59 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-08 20:39:01 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 20:40:58 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b269e7e22c457144521ff7a34d2599d963502b5
Cr-Commit-Position: refs/heads/master@{#417388}

Powered by Google App Engine
This is Rietveld 408576698