Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2318103002: Register V8 garbage collection reason histograms in histograms.xml (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register V8 garbage collection reason histograms in histograms.xml BUG=644713 Committed: https://crrev.com/d834cbb00a2f75483219a8f8bb3a40cf05a52134 Cr-Commit-Position: refs/heads/master@{#417270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ulan
PTAL. The CL that added the counters in V8 code is linked from the bug.
4 years, 3 months ago (2016-09-07 13:34:46 UTC) #2
Michael Lippautz
lgtm
4 years, 3 months ago (2016-09-07 13:39:44 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-07 15:08:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318103002/1
4 years, 3 months ago (2016-09-08 09:11:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/138108)
4 years, 3 months ago (2016-09-08 09:59:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318103002/1
4 years, 3 months ago (2016-09-08 12:08:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 13:22:48 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 13:25:51 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d834cbb00a2f75483219a8f8bb3a40cf05a52134
Cr-Commit-Position: refs/heads/master@{#417270}

Powered by Google App Engine
This is Rietveld 408576698