net/dns/host_resolver_impl.cc - Issue 23181010: Fast-fail WPAD detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_resolver_impl.cc

Issue 23181010: Fast-fail WPAD detection. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add HostResolverImpl test for SYSTEM_ONLY Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/host_resolver_impl.cc

diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc

index d10949f23cd9ee91fbef9aa8e909985a715a1563..7039f7548820537a60d3c635eaec63a98ca8eb43 100644

--- a/net/dns/host_resolver_impl.cc

+++ b/net/dns/host_resolver_impl.cc

@@ -1361,8 +1361,11 @@ class HostResolverImpl::Job : public PrioritizedDispatcher::Job {

queue_time_after_change);

}

+ bool system_only = key_.host_resolver_flags & HOST_RESOLVER_SYSTEM_ONLY;

// Caution: Job::Start must not complete synchronously.

- if (had_dns_config_ && !ResemblesMulticastDNSName(key_.hostname)) {

+ if (!system_only && had_dns_config_ &&

+ !ResemblesMulticastDNSName(key_.hostname)) {

StartDnsTask();

} else {

StartProcTask();