net/dns/mock_host_resolver.cc - Issue 23181010: Fast-fail WPAD detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mock_host_resolver.cc

Issue 23181010: Fast-fail WPAD detection. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase to LKGR Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/mock_host_resolver.cc

diff --git a/net/dns/mock_host_resolver.cc b/net/dns/mock_host_resolver.cc

index a1d46d06d3417adb2e970ea1e061553a3ee28c5a..83712ad6deacecb4e6980667719663ae6cf6273a 100644

--- a/net/dns/mock_host_resolver.cc

+++ b/net/dns/mock_host_resolver.cc

@@ -351,8 +351,8 @@ int RuleBasedHostResolverProc::Resolve(const std::string& host,

// in the rule's host_resolver_flags. However, the rule may have additional

// flags specified, in which case the flags should still be considered a

// match.

- bool matches_flags = (r->host_resolver_flags & host_resolver_flags) ==

- host_resolver_flags;

+ HostResolverFlags flags = host_resolver_flags & ~HOST_RESOLVER_SYSTEM_ONLY;

szym 2013/09/18 15:46:45 The comment above this statement does not match. S

+ bool matches_flags = (r->host_resolver_flags & flags) == flags;

if (matches_flags && matches_address_family &&

MatchPattern(host, r->host_pattern)) {

if (r->latency_ms != 0) {

« no previous file with comments | « net/dns/host_resolver_impl_unittest.cc ('k') | net/proxy/proxy_script_decider.h » ('j') | no next file with comments »