Issue 23181006: Add UMA stats to allow computing the average size of the TopSites blacklist per user.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23181006: Add UMA stats to allow computing the average size of the TopSites blacklist per user. (Closed)

Created:
7 years, 4 months ago by beaudoin

Modified:
7 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, browser-components-watch_chromium.org, sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add UMA stats to allow computing the average size of the TopSites blacklist per user. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218123

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/history/top_sites_impl.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

beaudoin

Hi Scott, Just a smallish review here, adding a UMA stats to learn more about ...

7 years, 4 months ago (2013-08-15 22:18:16 UTC) #1

beaudoin

Ooops, looks like Scott is OOO. Brett, can you do this review? Is very small. ...

7 years, 4 months ago (2013-08-15 22:19:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/23181006/3001

7 years, 4 months ago (2013-08-16 20:40:11 UTC) #4

beaudoin

7 years, 3 months ago (2013-09-05 15:09:44 UTC) #6

Message was sent while issue was closed.

On 2013/08/16 23:58:08, I haz the power (commit-bot) wrote:
> Change committed as 218123

For references, the histograms created in this CL were later added to
histograms.xml in this CL:
https://codereview.chromium.org/23983006/

Expand Messages | Collapse Messages