Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: chrome/browser/ui/webui/help/version_updater_win.cc

Issue 2318073002: Revert "Move on-demand update checks from the FILE thread to the blocking pool." (Closed)
Patch Set: sync to position 416913 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/help/version_updater_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/help/version_updater_win.cc
diff --git a/chrome/browser/ui/webui/help/version_updater_win.cc b/chrome/browser/ui/webui/help/version_updater_win.cc
index a181710d31a1abe586a20447977933adb8297fbb..d3cb556ea55d943d78a1097ec152ab416bbb57b7 100644
--- a/chrome/browser/ui/webui/help/version_updater_win.cc
+++ b/chrome/browser/ui/webui/help/version_updater_win.cc
@@ -39,7 +39,7 @@ void VersionUpdaterWin::CheckForUpdate(const StatusCallback& callback,
(base::win::OSInfo::GetInstance()->service_pack().major == 0) &&
!base::win::UserAccountControlIsEnabled())) {
callback_.Run(CHECKING, 0, base::string16());
- BeginUpdateCheckInBlockingPool(false /* !install_update_if_possible */);
+ BeginUpdateCheckOnFileThread(false /* !install_update_if_possible */);
}
}
@@ -66,7 +66,7 @@ void VersionUpdaterWin::OnUpdateCheckComplete(
} else {
// Notify the caller that the update is now beginning and initiate it.
status = UPDATING;
- BeginUpdateCheckInBlockingPool(true /* install_update_if_possible */);
+ BeginUpdateCheckOnFileThread(true /* install_update_if_possible */);
}
callback_.Run(status, 0, base::string16());
}
@@ -113,15 +113,12 @@ void VersionUpdaterWin::OnError(GoogleUpdateErrorCode error_code,
callback_.Run(status, 0, message);
}
-void VersionUpdaterWin::BeginUpdateCheckInBlockingPool(
+void VersionUpdaterWin::BeginUpdateCheckOnFileThread(
bool install_update_if_possible) {
// Disconnect from any previous attempts to avoid redundant callbacks.
weak_factory_.InvalidateWeakPtrs();
- base::SequencedWorkerPool* blocking_pool =
- content::BrowserThread::GetBlockingPool();
- BeginUpdateCheck(blocking_pool->GetSequencedTaskRunnerWithShutdownBehavior(
- blocking_pool->GetSequenceToken(),
- base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN),
+ BeginUpdateCheck(content::BrowserThread::GetTaskRunnerForThread(
+ content::BrowserThread::FILE),
g_browser_process->GetApplicationLocale(),
install_update_if_possible, owner_widget_,
weak_factory_.GetWeakPtr());
« no previous file with comments | « chrome/browser/ui/webui/help/version_updater_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698