Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: net/quic/chromium/quic_chromium_client_session.h

Issue 2318053004: Remove obsolete QUIC disabling code. (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_chromium_client_session.h
diff --git a/net/quic/chromium/quic_chromium_client_session.h b/net/quic/chromium/quic_chromium_client_session.h
index 5a2ac65315aceb3458f0c6dcb478cbb808526410..dcf436381f69a1cfa4bfa0f3b8435e178f1ecb7f 100644
--- a/net/quic/chromium/quic_chromium_client_session.h
+++ b/net/quic/chromium/quic_chromium_client_session.h
@@ -58,18 +58,6 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
public QuicChromiumPacketReader::Visitor,
public QuicChromiumPacketWriter::WriteErrorObserver {
public:
- // Reasons to disable QUIC, that is under certain pathological
- // connection errors. Note: these values must be kept in sync with
- // the corresponding values of QuicDisabledReason in:
- // tools/metrics/histograms/histograms.xml
- enum QuicDisabledReason {
ianswett 2016/09/08 19:37:02 Are we going to want this enum again in the near f
Ryan Hamilton 2016/09/08 19:42:02 I don't think so. But if we need it, we can add it
- QUIC_DISABLED_NOT = 0, // default, not disabled
- QUIC_DISABLED_PUBLIC_RESET_POST_HANDSHAKE = 1,
- QUIC_DISABLED_TIMEOUT_WITH_OPEN_STREAMS = 2,
- QUIC_DISABLED_BAD_PACKET_LOSS_RATE = 3,
- QUIC_DISABLED_MAX = 4,
- };
-
// An interface for observing events on a session.
class NET_EXPORT_PRIVATE Observer {
public:
@@ -249,8 +237,6 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
const QuicServerId& server_id() const { return server_id_; }
- QuicDisabledReason disabled_reason() const { return disabled_reason_; }
-
// Migrates session onto new socket, i.e., starts reading from
// |socket| in addition to any previous sockets, and sets |writer|
// to be the new default writer. Returns true if socket was
@@ -358,7 +344,6 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
bool going_away_;
// True when the session receives a go away from server due to port migration.
bool port_migration_detected_;
- QuicDisabledReason disabled_reason_;
TokenBindingSignatureMap token_binding_signatures_;
// UMA histogram counters for streams pushed to this session.
int streams_pushed_count_;

Powered by Google App Engine
This is Rietveld 408576698