Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2318053003: Remove gyp support from libvpx (Closed)

Created:
4 years, 3 months ago by Johann
Modified:
4 years, 3 months ago
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan, marpan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gyp support from libvpx Committed: https://crrev.com/6326fc6ef3c13f04d3e6cc5a5cc4405bcad98786 Cr-Commit-Position: refs/heads/master@{#417022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4835 lines) Patch
M third_party/libvpx/README.chromium View 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/libvpx/ads2gas.gypi View 1 chunk +0 lines, -54 lines 0 comments Download
A + third_party/libvpx/generate_gni.sh View 5 chunks +7 lines, -181 lines 0 comments Download
D third_party/libvpx/generate_gypi.sh View 1 chunk +0 lines, -621 lines 0 comments Download
D third_party/libvpx/libvpx.gyp View 1 chunk +0 lines, -300 lines 0 comments Download
D third_party/libvpx/libvpx_nacl.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_arm.gypi View 1 chunk +0 lines, -339 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_arm64.gypi View 1 chunk +0 lines, -393 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_arm_neon.gypi View 1 chunk +0 lines, -395 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_arm_neon_cpu_detect.gypi View 1 chunk +0 lines, -341 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_arm_neon_cpu_detect_intrinsics.gypi View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_generic.gypi View 1 chunk +0 lines, -337 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_mips.gypi View 1 chunk +0 lines, -339 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_nacl.gypi View 1 chunk +0 lines, -337 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_x86.gypi View 1 chunk +0 lines, -393 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_x86_64.gypi View 1 chunk +0 lines, -401 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_x86_64_intrinsics.gypi View 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/libvpx/libvpx_srcs_x86_intrinsics.gypi View 1 chunk +0 lines, -140 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Johann
Looks like WebRTC already switched to gn: https://bugs.chromium.org/p/webrtc/issues/detail?id=5949
4 years, 3 months ago (2016-09-07 18:13:58 UTC) #4
Johann
Henrik, looks like WebRTC is entirely on gn, yeah?
4 years, 3 months ago (2016-09-07 19:01:52 UTC) #8
kjellander_chromium
Yes, but still try to maintain a limited set of the GYP build due to ...
4 years, 3 months ago (2016-09-07 19:08:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318053003/1
4 years, 3 months ago (2016-09-07 19:09:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 19:15:22 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 19:17:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6326fc6ef3c13f04d3e6cc5a5cc4405bcad98786
Cr-Commit-Position: refs/heads/master@{#417022}

Powered by Google App Engine
This is Rietveld 408576698