c/browser, c/common, components M-N: Change ScopedTempDir::path() to GetPath()

chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_galleries/fileapi/itunes_data_provider.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 96 matching lines @@
 
   void SetLibraryChangeCallback(const base::Closure& callback) {
     EXPECT_TRUE(library_changed_callback_.is_null());
     library_changed_callback_ = callback;
   }
 
   ITunesDataProvider* data_provider() const {
     return ImportedMediaGalleryRegistry::ITunesDataProvider();
   }
 
-  const base::FilePath& library_dir() const {
-    return library_dir_.path();
-  }
+  const base::FilePath& library_dir() const { return library_dir_.GetPath(); }
 
   base::FilePath XmlFile() const {
-    return library_dir_.path().AppendASCII("library.xml");
+    return library_dir_.GetPath().AppendASCII("library.xml");

[Reilly Grant (use Gerrit), 2016/09/14 18:06:19]

I'm assuming this is correct because it is existing code but it would be good if
base::ScopedTempDir::GetPath() said whether or not the path was guaranteed to
have a trailing slash.

[vabr (Chromium), 2016/09/14 20:14:39]

This is guaranteed by FilePath itself ([1]), so dealing with trailing slashes is
transparent to ScopedTempDir.

[1]
https://cs.chromium.org/chromium/src/base/files/file_path.h?sq=package:chromi...

   }
 
   void ExpectTrackLocation(const std::string& artist, const std::string& album,
                            const std::string& track_name) {
     base::FilePath track =
         library_dir().AppendASCII(track_name).NormalizePathSeparators();
     EXPECT_EQ(track.value(),
               data_provider()->GetTrackLocation(
                   artist, album, track_name).NormalizePathSeparators().value());
   }
@@ skipping 329 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(ITunesDataProviderUniqueNameTest, UniqueNameTest) {
   RunTest();
 }
 
 IN_PROC_BROWSER_TEST_F(ITunesDataProviderEscapeTest, EscapeTest) {
   RunTest();
 }
 
 }  // namespace itunes