c/browser, c/common, components M-N: Change ScopedTempDir::path() to GetPath()

components/metrics/file_metrics_provider_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/file_metrics_provider.h"
 
 #include "base/files/file_util.h"
 #include "base/files/memory_mapped_file.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
@@ skipping 77 matching lines @@
   ~FileMetricsProviderTest() override {
     // Clear out any final remaining tasks.
     task_runner_->RunUntilIdle();
     // If a global histogram allocator exists at this point then it likely
     // acquired histograms that will continue to point to the released
     // memory and potentially cause use-after-free memory corruption.
     DCHECK(!base::GlobalHistogramAllocator::Get());
   }
 
   TestingPrefServiceSimple* prefs() { return prefs_.get(); }
-  base::FilePath temp_dir() { return temp_dir_.path(); }
+  base::FilePath temp_dir() { return temp_dir_.GetPath(); }
   base::FilePath metrics_file() {
-    return temp_dir_.path().AppendASCII(kMetricsFilename);
+    return temp_dir_.GetPath().AppendASCII(kMetricsFilename);
   }
 
   FileMetricsProvider* provider() {
     if (!provider_)
       provider_.reset(new FileMetricsProvider(task_runner_, prefs()));
     return provider_.get();
   }
 
   void OnDidCreateMetricsLog() {
     provider()->OnDidCreateMetricsLog();
@@ skipping 168 matching lines @@
       base::GlobalHistogramAllocator::Get();
   base::HistogramBase* histogram;
 
   // Create files starting with a timestamp a few minutes back.
   base::Time base_time = base::Time::Now() - base::TimeDelta::FromMinutes(10);
 
   // Create some files in an odd order. The files are "touched" back in time to
   // ensure that each file has a later timestamp on disk than the previous one.
   base::ScopedTempDir metrics_files;
   EXPECT_TRUE(metrics_files.CreateUniqueTempDir());
-  WriteMetricsFileAtTime(metrics_files.path().AppendASCII(".foo.pma"),
+  WriteMetricsFileAtTime(metrics_files.GetPath().AppendASCII(".foo.pma"),
                          allocator, base_time);
-  WriteMetricsFileAtTime(metrics_files.path().AppendASCII("_bar.pma"),
+  WriteMetricsFileAtTime(metrics_files.GetPath().AppendASCII("_bar.pma"),
                          allocator, base_time);
 
   histogram = base::Histogram::FactoryGet("h1", 1, 100, 10, 0);
   histogram->Add(1);
-  WriteMetricsFileAtTime(metrics_files.path().AppendASCII("a1.pma"), allocator,
+  WriteMetricsFileAtTime(metrics_files.GetPath().AppendASCII("a1.pma"),
+                         allocator,
                          base_time + base::TimeDelta::FromMinutes(1));
 
   histogram = base::Histogram::FactoryGet("h2", 1, 100, 10, 0);
   histogram->Add(2);
-  WriteMetricsFileAtTime(metrics_files.path().AppendASCII("c2.pma"), allocator,
+  WriteMetricsFileAtTime(metrics_files.GetPath().AppendASCII("c2.pma"),
+                         allocator,
                          base_time + base::TimeDelta::FromMinutes(2));
 
   histogram = base::Histogram::FactoryGet("h3", 1, 100, 10, 0);
   histogram->Add(3);
-  WriteMetricsFileAtTime(metrics_files.path().AppendASCII("b3.pma"), allocator,
+  WriteMetricsFileAtTime(metrics_files.GetPath().AppendASCII("b3.pma"),
+                         allocator,
                          base_time + base::TimeDelta::FromMinutes(3));
 
   histogram = base::Histogram::FactoryGet("h4", 1, 100, 10, 0);
   histogram->Add(3);
-  WriteMetricsFileAtTime(metrics_files.path().AppendASCII("d4.pma"), allocator,
+  WriteMetricsFileAtTime(metrics_files.GetPath().AppendASCII("d4.pma"),
+                         allocator,
                          base_time + base::TimeDelta::FromMinutes(4));
 
-  base::TouchFile(metrics_files.path().AppendASCII("b3.pma"),
+  base::TouchFile(metrics_files.GetPath().AppendASCII("b3.pma"),
                   base_time + base::TimeDelta::FromMinutes(5),
                   base_time + base::TimeDelta::FromMinutes(5));
 
-  WriteMetricsFileAtTime(metrics_files.path().AppendASCII("baz"), allocator,
+  WriteMetricsFileAtTime(metrics_files.GetPath().AppendASCII("baz"), allocator,
                          base_time + base::TimeDelta::FromMinutes(6));
 
   // The global allocator has to be detached here so that no metrics created
   // by code called below get stored in it as that would make for potential
   // use-after-free operations if that code is called again.
   base::GlobalHistogramAllocator::ReleaseForTesting();
 
   // Register the file and allow the "checker" task to run.
-  provider()->RegisterSource(metrics_files.path(),
+  provider()->RegisterSource(metrics_files.GetPath(),
                              FileMetricsProvider::SOURCE_HISTOGRAMS_ATOMIC_DIR,
                              FileMetricsProvider::ASSOCIATE_CURRENT_RUN,
                              kMetricsName);
 
   // Files could come out in the order: a1, c2, d4, b3. They are recognizeable
   // by the number of histograms contained within each.
   const uint32_t expect_order[] = {1, 2, 4, 3, 0};
   for (size_t i = 0; i < arraysize(expect_order); ++i) {
     // Record embedded snapshots via snapshot-manager.
     OnDidCreateMetricsLog();
     RunTasks();
     EXPECT_EQ(expect_order[i], GetSnapshotHistogramCount()) << i;
   }
 
-  EXPECT_FALSE(base::PathExists(metrics_files.path().AppendASCII("a1.pma")));
-  EXPECT_FALSE(base::PathExists(metrics_files.path().AppendASCII("c2.pma")));
-  EXPECT_FALSE(base::PathExists(metrics_files.path().AppendASCII("b3.pma")));
-  EXPECT_FALSE(base::PathExists(metrics_files.path().AppendASCII("d4.pma")));
-  EXPECT_TRUE(base::PathExists(metrics_files.path().AppendASCII(".foo.pma")));
-  EXPECT_TRUE(base::PathExists(metrics_files.path().AppendASCII("_bar.pma")));
-  EXPECT_TRUE(base::PathExists(metrics_files.path().AppendASCII("baz")));
+  EXPECT_FALSE(base::PathExists(metrics_files.GetPath().AppendASCII("a1.pma")));
+  EXPECT_FALSE(base::PathExists(metrics_files.GetPath().AppendASCII("c2.pma")));
+  EXPECT_FALSE(base::PathExists(metrics_files.GetPath().AppendASCII("b3.pma")));
+  EXPECT_FALSE(base::PathExists(metrics_files.GetPath().AppendASCII("d4.pma")));
+  EXPECT_TRUE(
+      base::PathExists(metrics_files.GetPath().AppendASCII(".foo.pma")));
+  EXPECT_TRUE(
+      base::PathExists(metrics_files.GetPath().AppendASCII("_bar.pma")));
+  EXPECT_TRUE(base::PathExists(metrics_files.GetPath().AppendASCII("baz")));
 }
 
 TEST_P(FileMetricsProviderTest, AccessReadWriteMetrics) {
   // Create a global histogram allocator that maps to a file.
   ASSERT_FALSE(PathExists(metrics_file()));
   base::GlobalHistogramAllocator::GetCreateHistogramResultHistogram();
   base::GlobalHistogramAllocator::CreateWithFile(
       metrics_file(),
       create_large_files_ ? kLargeFileSize : kSmallFileSize,
       0, kMetricsName);
@@ skipping 65 matching lines @@
   OnDidCreateMetricsLog();
   RunTasks();
   EXPECT_EQ(0U, GetSnapshotHistogramCount());
   EXPECT_TRUE(base::PathExists(metrics_file()));
   OnDidCreateMetricsLog();
   RunTasks();
   EXPECT_TRUE(base::PathExists(metrics_file()));
 }
 
 }  // namespace metrics