chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc - Issue 2318023002: //chrome/browser/chromeos: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

Issue 2318023002: //chrome/browser/chromeos: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Address comment and also remove non-trivial cases Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/default_app_order_unittest.cc ('k') | chrome/browser/chromeos/extensions/external_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

diff --git a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc b/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

index 4adcbd9e5be79c2543c07ef35abc6a8305f392a9..01008ae629792fcc886525527fe5615ab92c31ae 100644

--- a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

+++ b/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

@@ -142,7 +142,7 @@ DeviceLocalAccountExternalPolicyLoaderTest::

void DeviceLocalAccountExternalPolicyLoaderTest::SetUp() {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

- cache_dir_ = temp_dir_.path().Append(kCacheDir);

+ cache_dir_ = temp_dir_.GetPath().Append(kCacheDir);

ASSERT_TRUE(base::CreateDirectoryAndGetError(cache_dir_, NULL));

request_context_getter_ =

new net::TestURLRequestContextGetter(base::ThreadTaskRunnerHandle::Get());

@@ -275,9 +275,9 @@ TEST_F(DeviceLocalAccountExternalPolicyLoaderTest, ForceInstallListSet) {

// Create a temporary CRX file and return its path to the downloader.

EXPECT_TRUE(base::CopyFile(

test_dir_.Append(kExtensionCRXSourceDir).Append(kExtensionCRXFile),

- temp_dir_.path().Append(kExtensionCRXFile)));

+ temp_dir_.GetPath().Append(kExtensionCRXFile)));

fetcher->set_response_code(200);

- fetcher->SetResponseFilePath(temp_dir_.path().Append(kExtensionCRXFile));

+ fetcher->SetResponseFilePath(temp_dir_.GetPath().Append(kExtensionCRXFile));

fetcher->delegate()->OnURLFetchComplete(fetcher);

// Spin the loop. Verify that the loader announces the presence of a new CRX