Change simpleName of anonymous mixin applications.

Change simpleName of anonymous mixin applications.

BUG=http://dartbug.com/12464
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27132

[ngeoffray, 2013-08-15 19:08:21]

LGTM

https://codereview.chromium.org/23180004/diff/1/dart/sdk/lib/_internal/lib/js...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/23180004/diff/1/dart/sdk/lib/_internal/lib/js...
dart/sdk/lib/_internal/lib/js_mirrors.dart:494: return _cachedSimpleName =
(superName.contains(' with '))
Can't you check if the super class is a mixin application instead?

[ahe, 2013-08-15 19:35:13]

Thank you, Nicolas!

https://codereview.chromium.org/23180004/diff/1/dart/sdk/lib/_internal/lib/js...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/23180004/diff/1/dart/sdk/lib/_internal/lib/js...
dart/sdk/lib/_internal/lib/js_mirrors.dart:494: return _cachedSimpleName =
(superName.contains(' with '))
On 2013/08/15 19:08:21, ngeoffray wrote:
> Can't you check if the super class is a mixin application instead?

Perhaps, but I'm still working on this. Right now I create a JsClassMirror when
I see a named mixin application (which is why you suggestion would currently
work). But I need to change that for two reasons: the getter 'constructors'
below is wrong, and for named mixin applications, the owner of its members are
wrong. However, in that case, I'll probably have a nicer way to tell the
difference between a named and anonymous mixin application.

[ahe, 2013-09-03 22:42:26]

PTAL at the tests. The rest is unchanged.

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
File dart/tests/lib/mirrors/mixin_test.dart (right):

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
dart/tests/lib/mirrors/mixin_test.dart:64: 
Ryan's whitespace changes made it hard for me to merge mixin_dart2js_test back
into this test. So I undid them.

[ngeoffray, 2013-09-04 06:59:21]

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
File dart/tests/lib/mirrors/mixin_test.dart (right):

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
dart/tests/lib/mirrors/mixin_test.dart:99: owner = 'MixinApplication'; /// 01:
ok
Does that mean the base file is a negative test?

[ahe, 2013-09-04 10:17:07]

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
File dart/tests/lib/mirrors/mixin_test.dart (right):

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
dart/tests/lib/mirrors/mixin_test.dart:99: owner = 'MixinApplication'; /// 01:
ok
On 2013/09/04 06:59:21, ngeoffray wrote:
> Does that mean the base file is a negative test?

Not exactly. It means that you have two positive tests. However, not both of
them can actually pass on the same implementation. 

So this is an alternative to having two files that can start diverging between
dart2js and the VM.

In this case, I think it more clearly demonstrates that the VM and dart2js
disagree on who is the owner of an anonymous mixin application. This wasn't
obvious before. See line113 for an example.

[ngeoffray, 2013-09-04 10:23:50]

LGTM!

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
File dart/tests/lib/mirrors/mixin_test.dart (right):

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
dart/tests/lib/mirrors/mixin_test.dart:99: owner = 'MixinApplication'; /// 01:
ok
On 2013/09/04 10:17:07, ahe wrote:
> On 2013/09/04 06:59:21, ngeoffray wrote:
> > Does that mean the base file is a negative test?
> 
> Not exactly. It means that you have two positive tests. However, not both of
> them can actually pass on the same implementation. 
> 
> So this is an alternative to having two files that can start diverging between
> dart2js and the VM.
> 
> In this case, I think it more clearly demonstrates that the VM and dart2js
> disagree on who is the owner of an anonymous mixin application. This wasn't
> obvious before. See line113 for an example. 

OK, could you please add a top-level comment on this test that explains what you
just described? Thanks!

[ahe, 2013-09-04 13:31:39]

Thank you

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
File dart/tests/lib/mirrors/mixin_test.dart (right):

https://codereview.chromium.org/23180004/diff/7001/dart/tests/lib/mirrors/mix...
dart/tests/lib/mirrors/mixin_test.dart:99: owner = 'MixinApplication'; /// 01:
ok
On 2013/09/04 10:23:50, ngeoffray wrote:
> On 2013/09/04 10:17:07, ahe wrote:
> > On 2013/09/04 06:59:21, ngeoffray wrote:
> > > Does that mean the base file is a negative test?
> > 
> > Not exactly. It means that you have two positive tests. However, not both of
> > them can actually pass on the same implementation. 
> > 
> > So this is an alternative to having two files that can start diverging
between
> > dart2js and the VM.
> > 
> > In this case, I think it more clearly demonstrates that the VM and dart2js
> > disagree on who is the owner of an anonymous mixin application. This wasn't
> > obvious before. See line113 for an example. 
> 
> OK, could you please add a top-level comment on this test that explains what
you
> just described? Thanks!

Done.

[ahe, 2013-09-04 14:38:25]

Committed patchset #4 manually as r27132 (presubmit successful).