Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2317993004: Move OnURLsDeleted from NTPSnippetsService to ContentSuggestionsService (Closed)

Created:
4 years, 3 months ago by Marc Treib
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Move OnURLsDeleted from NTPSnippetsService to ContentSuggestionsService This CL makes ContentSuggestionsService an observer of HistoryService, so that all providers can be notified about deleted URLs. The call is redirected to ClearHistory(). NTPSnippetsService's HistoryService observer code is replaced with the notification above. BUG=643608 Review-Url: https://codereview.chromium.org/2292003002 Cr-Commit-Position: refs/heads/master@{#416518} (cherry picked from commit 45941154e2a8e0766210a65d2c12bf40a2c95d9a) Committed: https://chromium.googlesource.com/chromium/src/+/14ed9ad4d92994f05c83d15c2e21154c0dcbdab7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -65 lines) Patch
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.h View 5 chunks +21 lines, -2 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.cc View 3 chunks +55 lines, -2 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 5 chunks +1 line, -18 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 4 chunks +0 lines, -28 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 3 months ago (2016-09-07 09:54:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
14ed9ad4d92994f05c83d15c2e21154c0dcbdab7.

Powered by Google App Engine
This is Rietveld 408576698