Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: components/drive/resource_metadata_storage_unittest.cc

Issue 2317993003: //chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/drive/resource_metadata_storage.h" 5 #include "components/drive/resource_metadata_storage.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 13 matching lines...) Expand all
24 24
25 namespace drive { 25 namespace drive {
26 namespace internal { 26 namespace internal {
27 27
28 class ResourceMetadataStorageTest : public testing::Test { 28 class ResourceMetadataStorageTest : public testing::Test {
29 protected: 29 protected:
30 void SetUp() override { 30 void SetUp() override {
31 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 31 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
32 32
33 storage_.reset(new ResourceMetadataStorage( 33 storage_.reset(new ResourceMetadataStorage(
34 temp_dir_.path(), base::ThreadTaskRunnerHandle::Get().get())); 34 temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
35 ASSERT_TRUE(storage_->Initialize()); 35 ASSERT_TRUE(storage_->Initialize());
36 } 36 }
37 37
38 // Overwrites |storage_|'s version. 38 // Overwrites |storage_|'s version.
39 void SetDBVersion(int version) { 39 void SetDBVersion(int version) {
40 ResourceMetadataHeader header; 40 ResourceMetadataHeader header;
41 ASSERT_EQ(FILE_ERROR_OK, storage_->GetHeader(&header)); 41 ASSERT_EQ(FILE_ERROR_OK, storage_->GetHeader(&header));
42 header.set_version(version); 42 header.set_version(version);
43 EXPECT_EQ(FILE_ERROR_OK, storage_->PutHeader(header)); 43 EXPECT_EQ(FILE_ERROR_OK, storage_->PutHeader(header));
44 } 44 }
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 entry2.set_local_id(child_id1); 264 entry2.set_local_id(child_id1);
265 entry2.set_parent_local_id(parent_id1); 265 entry2.set_parent_local_id(parent_id1);
266 entry2.set_base_name(child_name1); 266 entry2.set_base_name(child_name1);
267 267
268 // Put some data. 268 // Put some data.
269 EXPECT_EQ(FILE_ERROR_OK, storage_->PutEntry(entry1)); 269 EXPECT_EQ(FILE_ERROR_OK, storage_->PutEntry(entry1));
270 EXPECT_EQ(FILE_ERROR_OK, storage_->PutEntry(entry2)); 270 EXPECT_EQ(FILE_ERROR_OK, storage_->PutEntry(entry2));
271 271
272 // Close DB and reopen. 272 // Close DB and reopen.
273 storage_.reset(new ResourceMetadataStorage( 273 storage_.reset(new ResourceMetadataStorage(
274 temp_dir_.path(), base::ThreadTaskRunnerHandle::Get().get())); 274 temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
275 ASSERT_TRUE(storage_->Initialize()); 275 ASSERT_TRUE(storage_->Initialize());
276 276
277 // Can read data. 277 // Can read data.
278 ResourceEntry result; 278 ResourceEntry result;
279 EXPECT_EQ(FILE_ERROR_OK, storage_->GetEntry(parent_id1, &result)); 279 EXPECT_EQ(FILE_ERROR_OK, storage_->GetEntry(parent_id1, &result));
280 280
281 EXPECT_EQ(FILE_ERROR_OK, storage_->GetEntry(child_id1, &result)); 281 EXPECT_EQ(FILE_ERROR_OK, storage_->GetEntry(child_id1, &result));
282 EXPECT_EQ(parent_id1, result.parent_local_id()); 282 EXPECT_EQ(parent_id1, result.parent_local_id());
283 EXPECT_EQ(child_name1, result.base_name()); 283 EXPECT_EQ(child_name1, result.base_name());
284 284
(...skipping 23 matching lines...) Expand all
308 batch.Put("file:abcd", serialized_entry); 308 batch.Put("file:abcd", serialized_entry);
309 309
310 FileCacheEntry cache_entry; 310 FileCacheEntry cache_entry;
311 EXPECT_TRUE(cache_entry.SerializeToString(&serialized_entry)); 311 EXPECT_TRUE(cache_entry.SerializeToString(&serialized_entry));
312 batch.Put(std::string("file:abcd") + '\0' + "CACHE", serialized_entry); 312 batch.Put(std::string("file:abcd") + '\0' + "CACHE", serialized_entry);
313 313
314 EXPECT_TRUE(resource_map()->Write(leveldb::WriteOptions(), &batch).ok()); 314 EXPECT_TRUE(resource_map()->Write(leveldb::WriteOptions(), &batch).ok());
315 315
316 // Upgrade and reopen. 316 // Upgrade and reopen.
317 storage_.reset(); 317 storage_.reset();
318 EXPECT_TRUE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.path())); 318 EXPECT_TRUE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.GetPath()));
319 storage_.reset(new ResourceMetadataStorage( 319 storage_.reset(new ResourceMetadataStorage(
320 temp_dir_.path(), base::ThreadTaskRunnerHandle::Get().get())); 320 temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
321 ASSERT_TRUE(storage_->Initialize()); 321 ASSERT_TRUE(storage_->Initialize());
322 322
323 // Resource-ID-to-local-ID mapping is added. 323 // Resource-ID-to-local-ID mapping is added.
324 std::string id; 324 std::string id;
325 EXPECT_EQ(FILE_ERROR_OK, 325 EXPECT_EQ(FILE_ERROR_OK,
326 storage_->GetIdByResourceId("abcd", &id)); // "file:" is dropped. 326 storage_->GetIdByResourceId("abcd", &id)); // "file:" is dropped.
327 327
328 // Data is erased, except cache entries. 328 // Data is erased, except cache entries.
329 int64_t largest_changestamp = 0; 329 int64_t largest_changestamp = 0;
330 EXPECT_EQ(FILE_ERROR_OK, 330 EXPECT_EQ(FILE_ERROR_OK,
(...skipping 29 matching lines...) Expand all
360 FileCacheEntry cache_entry; 360 FileCacheEntry cache_entry;
361 EXPECT_TRUE(cache_entry.SerializeToString(&serialized_entry)); 361 EXPECT_TRUE(cache_entry.SerializeToString(&serialized_entry));
362 batch.Put(local_id + '\0' + "CACHE", serialized_entry); 362 batch.Put(local_id + '\0' + "CACHE", serialized_entry);
363 363
364 batch.Put('\0' + std::string("ID") + '\0' + resource_id, local_id); 364 batch.Put('\0' + std::string("ID") + '\0' + resource_id, local_id);
365 365
366 EXPECT_TRUE(resource_map()->Write(leveldb::WriteOptions(), &batch).ok()); 366 EXPECT_TRUE(resource_map()->Write(leveldb::WriteOptions(), &batch).ok());
367 367
368 // Upgrade and reopen. 368 // Upgrade and reopen.
369 storage_.reset(); 369 storage_.reset();
370 EXPECT_TRUE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.path())); 370 EXPECT_TRUE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.GetPath()));
371 storage_.reset(new ResourceMetadataStorage( 371 storage_.reset(new ResourceMetadataStorage(
372 temp_dir_.path(), base::ThreadTaskRunnerHandle::Get().get())); 372 temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
373 ASSERT_TRUE(storage_->Initialize()); 373 ASSERT_TRUE(storage_->Initialize());
374 374
375 // Data is erased, except cache and id mapping entries. 375 // Data is erased, except cache and id mapping entries.
376 std::string id; 376 std::string id;
377 EXPECT_EQ(FILE_ERROR_OK, storage_->GetIdByResourceId(resource_id, &id)); 377 EXPECT_EQ(FILE_ERROR_OK, storage_->GetIdByResourceId(resource_id, &id));
378 EXPECT_EQ(local_id, id); 378 EXPECT_EQ(local_id, id);
379 int64_t largest_changestamp = 0; 379 int64_t largest_changestamp = 0;
380 EXPECT_EQ(FILE_ERROR_OK, 380 EXPECT_EQ(FILE_ERROR_OK,
381 storage_->GetLargestChangestamp(&largest_changestamp)); 381 storage_->GetLargestChangestamp(&largest_changestamp));
382 EXPECT_EQ(0, largest_changestamp); 382 EXPECT_EQ(0, largest_changestamp);
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 // Put another cache entry which is not accompanied by a ResourceEntry. 421 // Put another cache entry which is not accompanied by a ResourceEntry.
422 cache_entry.set_md5(md5_2); 422 cache_entry.set_md5(md5_2);
423 EXPECT_TRUE(cache_entry.SerializeToString(&serialized_entry)); 423 EXPECT_TRUE(cache_entry.SerializeToString(&serialized_entry));
424 batch.Put(local_id2 + '\0' + "CACHE", serialized_entry); 424 batch.Put(local_id2 + '\0' + "CACHE", serialized_entry);
425 batch.Put('\0' + std::string("ID") + '\0' + resource_id2, local_id2); 425 batch.Put('\0' + std::string("ID") + '\0' + resource_id2, local_id2);
426 426
427 EXPECT_TRUE(resource_map()->Write(leveldb::WriteOptions(), &batch).ok()); 427 EXPECT_TRUE(resource_map()->Write(leveldb::WriteOptions(), &batch).ok());
428 428
429 // Upgrade and reopen. 429 // Upgrade and reopen.
430 storage_.reset(); 430 storage_.reset();
431 EXPECT_TRUE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.path())); 431 EXPECT_TRUE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.GetPath()));
432 storage_.reset(new ResourceMetadataStorage( 432 storage_.reset(new ResourceMetadataStorage(
433 temp_dir_.path(), base::ThreadTaskRunnerHandle::Get().get())); 433 temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
434 ASSERT_TRUE(storage_->Initialize()); 434 ASSERT_TRUE(storage_->Initialize());
435 435
436 // No data is lost. 436 // No data is lost.
437 int64_t largest_changestamp = 0; 437 int64_t largest_changestamp = 0;
438 EXPECT_EQ(FILE_ERROR_OK, 438 EXPECT_EQ(FILE_ERROR_OK,
439 storage_->GetLargestChangestamp(&largest_changestamp)); 439 storage_->GetLargestChangestamp(&largest_changestamp));
440 EXPECT_EQ(kLargestChangestamp, largest_changestamp); 440 EXPECT_EQ(kLargestChangestamp, largest_changestamp);
441 441
442 std::string id; 442 std::string id;
443 EXPECT_EQ(FILE_ERROR_OK, storage_->GetIdByResourceId(resource_id, &id)); 443 EXPECT_EQ(FILE_ERROR_OK, storage_->GetIdByResourceId(resource_id, &id));
(...skipping 15 matching lines...) Expand all
459 // Put some data. 459 // Put some data.
460 EXPECT_EQ(FILE_ERROR_OK, 460 EXPECT_EQ(FILE_ERROR_OK,
461 storage_->SetLargestChangestamp(kLargestChangestamp)); 461 storage_->SetLargestChangestamp(kLargestChangestamp));
462 ResourceEntry entry; 462 ResourceEntry entry;
463 entry.set_local_id(key1); 463 entry.set_local_id(key1);
464 EXPECT_EQ(FILE_ERROR_OK, storage_->PutEntry(entry)); 464 EXPECT_EQ(FILE_ERROR_OK, storage_->PutEntry(entry));
465 465
466 // Set newer version, upgrade and reopen DB. 466 // Set newer version, upgrade and reopen DB.
467 SetDBVersion(ResourceMetadataStorage::kDBVersion + 1); 467 SetDBVersion(ResourceMetadataStorage::kDBVersion + 1);
468 storage_.reset(); 468 storage_.reset();
469 EXPECT_FALSE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.path())); 469 EXPECT_FALSE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.GetPath()));
470 storage_.reset(new ResourceMetadataStorage( 470 storage_.reset(new ResourceMetadataStorage(
471 temp_dir_.path(), base::ThreadTaskRunnerHandle::Get().get())); 471 temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
472 ASSERT_TRUE(storage_->Initialize()); 472 ASSERT_TRUE(storage_->Initialize());
473 473
474 // Data is erased because of the incompatible version. 474 // Data is erased because of the incompatible version.
475 int64_t largest_changestamp = 0; 475 int64_t largest_changestamp = 0;
476 EXPECT_EQ(FILE_ERROR_OK, 476 EXPECT_EQ(FILE_ERROR_OK,
477 storage_->GetLargestChangestamp(&largest_changestamp)); 477 storage_->GetLargestChangestamp(&largest_changestamp));
478 EXPECT_EQ(0, largest_changestamp); 478 EXPECT_EQ(0, largest_changestamp);
479 EXPECT_EQ(FILE_ERROR_NOT_FOUND, storage_->GetEntry(key1, &entry)); 479 EXPECT_EQ(FILE_ERROR_NOT_FOUND, storage_->GetEntry(key1, &entry));
480 } 480 }
481 481
(...skipping 10 matching lines...) Expand all
492 batch.Put("id1", serialized_entry); 492 batch.Put("id1", serialized_entry);
493 batch.Put('\0' + std::string("ID") + '\0' + "resource_id1", "id1"); 493 batch.Put('\0' + std::string("ID") + '\0' + "resource_id1", "id1");
494 494
495 // Put an ID entry without any corresponding entries. 495 // Put an ID entry without any corresponding entries.
496 batch.Put('\0' + std::string("ID") + '\0' + "resource_id2", "id3"); 496 batch.Put('\0' + std::string("ID") + '\0' + "resource_id2", "id3");
497 497
498 EXPECT_TRUE(resource_map()->Write(leveldb::WriteOptions(), &batch).ok()); 498 EXPECT_TRUE(resource_map()->Write(leveldb::WriteOptions(), &batch).ok());
499 499
500 // Upgrade and reopen. 500 // Upgrade and reopen.
501 storage_.reset(); 501 storage_.reset();
502 EXPECT_TRUE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.path())); 502 EXPECT_TRUE(ResourceMetadataStorage::UpgradeOldDB(temp_dir_.GetPath()));
503 storage_.reset(new ResourceMetadataStorage( 503 storage_.reset(new ResourceMetadataStorage(
504 temp_dir_.path(), base::ThreadTaskRunnerHandle::Get().get())); 504 temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
505 ASSERT_TRUE(storage_->Initialize()); 505 ASSERT_TRUE(storage_->Initialize());
506 506
507 // Only the unused entry is deleted. 507 // Only the unused entry is deleted.
508 std::string id; 508 std::string id;
509 EXPECT_EQ(FILE_ERROR_OK, storage_->GetIdByResourceId("resource_id1", &id)); 509 EXPECT_EQ(FILE_ERROR_OK, storage_->GetIdByResourceId("resource_id1", &id));
510 EXPECT_EQ("id1", id); 510 EXPECT_EQ("id1", id);
511 EXPECT_EQ(FILE_ERROR_NOT_FOUND, 511 EXPECT_EQ(FILE_ERROR_NOT_FOUND,
512 storage_->GetIdByResourceId("resource_id2", &id)); 512 storage_->GetIdByResourceId("resource_id2", &id));
513 } 513 }
514 514
515 TEST_F(ResourceMetadataStorageTest, WrongPath) { 515 TEST_F(ResourceMetadataStorageTest, WrongPath) {
516 // Create a file. 516 // Create a file.
517 base::FilePath path; 517 base::FilePath path;
518 ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.path(), &path)); 518 ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.GetPath(), &path));
519 519
520 storage_.reset(new ResourceMetadataStorage( 520 storage_.reset(new ResourceMetadataStorage(
521 path, base::ThreadTaskRunnerHandle::Get().get())); 521 path, base::ThreadTaskRunnerHandle::Get().get()));
522 // Cannot initialize DB beacause the path does not point a directory. 522 // Cannot initialize DB beacause the path does not point a directory.
523 ASSERT_FALSE(storage_->Initialize()); 523 ASSERT_FALSE(storage_->Initialize());
524 } 524 }
525 525
526 TEST_F(ResourceMetadataStorageTest, RecoverCacheEntriesFromTrashedResourceMap) { 526 TEST_F(ResourceMetadataStorageTest, RecoverCacheEntriesFromTrashedResourceMap) {
527 // Put entry with id_foo. 527 // Put entry with id_foo.
528 ResourceEntry entry; 528 ResourceEntry entry;
(...skipping 11 matching lines...) Expand all
540 entry.mutable_file_specific_info()->mutable_cache_state()->set_md5("md5_bar"); 540 entry.mutable_file_specific_info()->mutable_cache_state()->set_md5("md5_bar");
541 entry.mutable_file_specific_info()->mutable_cache_state()->set_is_dirty(true); 541 entry.mutable_file_specific_info()->mutable_cache_state()->set_is_dirty(true);
542 EXPECT_EQ(FILE_ERROR_OK, storage_->PutEntry(entry)); 542 EXPECT_EQ(FILE_ERROR_OK, storage_->PutEntry(entry));
543 543
544 // Remove parent-child relationship to make the DB invalid. 544 // Remove parent-child relationship to make the DB invalid.
545 RemoveChild("id_foo", "bar"); 545 RemoveChild("id_foo", "bar");
546 EXPECT_FALSE(CheckValidity()); 546 EXPECT_FALSE(CheckValidity());
547 547
548 // Reopen. This should result in trashing the DB. 548 // Reopen. This should result in trashing the DB.
549 storage_.reset(new ResourceMetadataStorage( 549 storage_.reset(new ResourceMetadataStorage(
550 temp_dir_.path(), base::ThreadTaskRunnerHandle::Get().get())); 550 temp_dir_.GetPath(), base::ThreadTaskRunnerHandle::Get().get()));
551 ASSERT_TRUE(storage_->Initialize()); 551 ASSERT_TRUE(storage_->Initialize());
552 552
553 // Recover cache entries from the trashed DB. 553 // Recover cache entries from the trashed DB.
554 ResourceMetadataStorage::RecoveredCacheInfoMap recovered_cache_info; 554 ResourceMetadataStorage::RecoveredCacheInfoMap recovered_cache_info;
555 storage_->RecoverCacheInfoFromTrashedResourceMap(&recovered_cache_info); 555 storage_->RecoverCacheInfoFromTrashedResourceMap(&recovered_cache_info);
556 EXPECT_EQ(2U, recovered_cache_info.size()); 556 EXPECT_EQ(2U, recovered_cache_info.size());
557 EXPECT_FALSE(recovered_cache_info["id_foo"].is_dirty); 557 EXPECT_FALSE(recovered_cache_info["id_foo"].is_dirty);
558 EXPECT_EQ("md5_foo", recovered_cache_info["id_foo"].md5); 558 EXPECT_EQ("md5_foo", recovered_cache_info["id_foo"].md5);
559 EXPECT_EQ("foo", recovered_cache_info["id_foo"].title); 559 EXPECT_EQ("foo", recovered_cache_info["id_foo"].title);
560 EXPECT_TRUE(recovered_cache_info["id_bar"].is_dirty); 560 EXPECT_TRUE(recovered_cache_info["id_bar"].is_dirty);
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 EXPECT_EQ(FILE_ERROR_OK, storage_->RemoveEntry(key3)); 629 EXPECT_EQ(FILE_ERROR_OK, storage_->RemoveEntry(key3));
630 EXPECT_TRUE(CheckValidity()); 630 EXPECT_TRUE(CheckValidity());
631 631
632 // Remove key1. 632 // Remove key1.
633 EXPECT_EQ(FILE_ERROR_OK, storage_->RemoveEntry(key1)); 633 EXPECT_EQ(FILE_ERROR_OK, storage_->RemoveEntry(key1));
634 EXPECT_TRUE(CheckValidity()); 634 EXPECT_TRUE(CheckValidity());
635 } 635 }
636 636
637 } // namespace internal 637 } // namespace internal
638 } // namespace drive 638 } // namespace drive
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698