Enable manual password autofilling if the username field is read-only.

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 685 matching lines @@
   const blink::WebInputElement* element = toWebInputElement(&control_element);
   if (!element)
     return false;
 
   blink::WebInputElement username_element;
   blink::WebInputElement password_element;
   PasswordInfo* password_info;
 
   if (!FindPasswordInfoForElement(*element, &username_element,
                                   &password_element, &password_info) ||
-      (!username_element.isNull() &&
-       !IsElementAutocompletable(username_element)) ||
       !IsElementAutocompletable(password_element)) {
     return false;
   }
 
   password_info->password_was_edited_last = false;
   if (element->isPasswordField()) {
     password_info->password_field_suggestion_was_accepted = true;
     password_info->password_field = password_element;
   } else if (!username_element.isNull()) {

[vabr (Chromium), 2016/09/07 08:32:53]

Should we only execute this branch if also
IsElementAutocompletable(username_element)?

[sense (YandexTeam), 2016/09/07 11:40:14]

I think it's OK to add this check to exclude possible incorrect behaviour (and
also add it in the PreviewSuggestion).
But I haven't found a form where this branch can be activated - you can't
preview an autofill data by clicking on read-only username field. I tried to
create password form with multiple fields, but suggestion popup activates only
on the username or password fields.

[vabr (Chromium), 2016/09/08 08:48:58]

Ah, you are right, the first if-branch is used instead.
Nevertheless, I think you did the correct think by updating the condition on
this line, because it might happen that the UI will change slightly in the
future.

     username_element.setValue(blink::WebString(username), true);
     username_element.setAutofilled(true);
     UpdateFieldValueAndPropertiesMaskMap(username_element, &username,
                                          FieldPropertiesFlags::AUTOFILLED,
                                          &field_value_and_properties_map_);
   }
 
   password_element.setValue(blink::WebString(password), true);
   password_element.setAutofilled(true);
   UpdateFieldValueAndPropertiesMaskMap(password_element, &password,
@@ skipping 15 matching lines @@
   const blink::WebInputElement* element = toWebInputElement(&control_element);
   if (!element)
     return false;
 
   blink::WebInputElement username_element;
   blink::WebInputElement password_element;
   PasswordInfo* password_info;
 
   if (!FindPasswordInfoForElement(*element, &username_element,
                                   &password_element, &password_info) ||
-      (!username_element.isNull() &&
-       !IsElementAutocompletable(username_element)) ||
       !IsElementAutocompletable(password_element)) {
     return false;
   }
 
   if (!element->isPasswordField() && !username_element.isNull()) {
     if (username_query_prefix_.empty())
       username_query_prefix_ = username_element.value();
 
     was_username_autofilled_ = username_element.isAutofilled();
     username_element.setSuggestedValue(username);
@@ skipping 729 matching lines @@
          !(provisionally_saved_form_->password_value.empty() &&
          provisionally_saved_form_->new_password_value.empty());
 }
 
 const mojom::AutofillDriverPtr& PasswordAutofillAgent::GetAutofillDriver() {
   DCHECK(autofill_agent_);
   return autofill_agent_->GetAutofillDriver();
 }
 
 }  // namespace autofill