Issue 231793005: Use original context for AppListSyncableServiceFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231793005: Use original context for AppListSyncableServiceFactory (Closed)

Created:
6 years, 8 months ago by stevenjb

Modified:
6 years, 8 months ago

Reviewers:
xiyuan, tbarzic

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use original context for AppListSyncableServiceFactory BUG=361508 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263067

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	chrome/browser/ui/app_list/app_list_syncable_service_factory.cc	View		3 chunks	+12 lines, -6 lines	0 comments	Download

Total messages: 6 (0 generated)

xiyuan

LGTM Let's also wait for Tony to make sure we don't regress http://crbug.com/335426.

6 years, 8 months ago (2014-04-10 01:26:05 UTC) #2

tbarzic

On 2014/04/10 01:26:05, xiyuan wrote: > LGTM > > Let's also wait for Tony to ...

6 years, 8 months ago (2014-04-10 02:40:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/231793005/1

6 years, 8 months ago (2014-04-10 17:49:02 UTC) #5

Message was sent while issue was closed.

Change committed as 263067