cc: Change preraster/predecode split to be half of max skewport extent.

cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

The tough scrolling cases seems to indicate that checkerboards
remain roughly the same with this patch.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1a4f3af8e0b96d1517939be11395132f9faa5e8c
Cr-Commit-Position: refs/heads/master@{#417164}

[vmpstr, 2016-09-06 23:14:43]

Description was changed from

==========
cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

<put tough scrolling cases results here>
==========

to

==========
cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

<put tough scrolling cases results here>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[vmpstr, 2016-09-07 21:27:14]

Description was changed from

==========
cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

<put tough scrolling cases results here>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

The tough scrolling cases seems to indicate that checkerboards
remain roughly the same with this patch.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[vmpstr, 2016-09-07 21:27:14]

vmpstr@chromium.org changed reviewers:
+ enne@chromium.org

[vmpstr, 2016-09-07 21:27:22]

Please take a look.

[enne (OOO), 2016-09-07 22:03:21]

So the goal here is to limit pre-raster work when the skewport is moving slowly?

https://codereview.chromium.org/2317913002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/2317913002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:805: tile_priority.distance_to_visible > 0.5f *
max_skewport_extent_);
distance_to_visible is in screen space, but max skewport extent is in...content
space? Am I mistaken?

[vmpstr, 2016-09-07 22:06:40]

> So the goal here is to limit pre-raster work when the skewport is moving
slowly?

Yep.

https://codereview.chromium.org/2317913002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/2317913002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:805: tile_priority.distance_to_visible > 0.5f *
max_skewport_extent_);
On 2016/09/07 22:03:20, enne wrote:
> distance_to_visible is in screen space, but max skewport extent is
in...content
> space? Am I mistaken?

max skewport extent is in screen space as well (it's multiplied by the scale).
I'll change the variable name to be more clear.

[enne (OOO), 2016-09-07 22:13:03]

https://codereview.chromium.org/2317913002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/2317913002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:805: tile_priority.distance_to_visible > 0.5f *
max_skewport_extent_);
On 2016/09/07 at 22:06:40, vmpstr wrote:
> On 2016/09/07 22:03:20, enne wrote:
> > distance_to_visible is in screen space, but max skewport extent is
in...content
> > space? Am I mistaken?
> 
> max skewport extent is in screen space as well (it's multiplied by the scale).
I'll change the variable name to be more clear.

Oh right, I see that now.  More descriptive variable names about spaces would be
super appreciated.  :)

[vmpstr, 2016-09-07 22:48:28]

PTAL

https://codereview.chromium.org/2317913002/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/2317913002/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:805: tile_priority.distance_to_visible > 0.5f *
max_skewport_extent_);
On 2016/09/07 22:13:03, enne wrote:
> On 2016/09/07 at 22:06:40, vmpstr wrote:
> > On 2016/09/07 22:03:20, enne wrote:
> > > distance_to_visible is in screen space, but max skewport extent is
> in...content
> > > space? Am I mistaken?
> > 
> > max skewport extent is in screen space as well (it's multiplied by the
scale).
> I'll change the variable name to be more clear.
> 
> Oh right, I see that now.  More descriptive variable names about spaces would
be
> super appreciated.  :)

Done.

[enne (OOO), 2016-09-08 00:03:33]

lgtm

[vmpstr, 2016-09-08 00:19:15]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:19:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 00:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:41:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2016-09-08 01:09:29]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-09-08 01:09:29]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2317913002/#ps40001
(title: "compile fix")

[commit-bot: I haz the power, 2016-09-08 01:09:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 02:14:56]

Description was changed from

==========
cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

The tough scrolling cases seems to indicate that checkerboards
remain roughly the same with this patch.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

The tough scrolling cases seems to indicate that checkerboards
remain roughly the same with this patch.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-08 02:14:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 02:17:01]

Description was changed from

==========
cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

The tough scrolling cases seems to indicate that checkerboards
remain roughly the same with this patch.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Change preraster/predecode split to be half of max skewport extent.

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

The tough scrolling cases seems to indicate that checkerboards
remain roughly the same with this patch.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1a4f3af8e0b96d1517939be11395132f9faa5e8c
Cr-Commit-Position: refs/heads/master@{#417164}
==========

[commit-bot: I haz the power, 2016-09-08 02:17:01]

Patchset 3 (id:??) landed as
https://crrev.com/1a4f3af8e0b96d1517939be11395132f9faa5e8c
Cr-Commit-Position: refs/heads/master@{#417164}