Issue 2317873002: Revert of Merged: Disallow tail calls from async functions and generators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2317873002: Revert of Merged: Disallow tail calls from async functions and generators (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg

Modified:
4 years, 3 months ago

Reviewers:
adamk

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan

Target Ref:
refs/pending/branch-heads/5.4

Project:
v8

Visibility:
Public.

Revert of Merged: Disallow tail calls from async functions and generators (patchset #3 id:40001 of https://codereview.chromium.org/2313723007/ ) Reason for revert: Mistaken revert to the wrong base Original issue's description: > Merged: Disallow tail calls from async functions and generators > > Revision: 5af4cd984067f4e316aea04ef381a00724b5a8bf > > BUG=chromium:639270, v8:5301 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=adamk@chromium.org, adamk > > Committed: https://chromium.googlesource.com/v8/v8/+/51c8996ee36aaee5f5fee04b0747ea27194937b7 TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:639270, v8:5301

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -15 lines)			Patch
M	src/parsing/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/parsing/parser-base.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	test/mjsunit/es8/syntactic-tail-call-parsing.js	View	4 chunks	+3 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

Dan Ehrenberg

Created Revert of Merged: Disallow tail calls from async functions and generators

4 years, 3 months ago (2016-09-06 22:06:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317873002/1

4 years, 3 months ago (2016-09-06 22:06:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1)