Remove calls to deprecated MessageLoop methods in media.

Remove calls to deprecated MessageLoop methods in media.

This CL (hopefully) removes all calls to these methods in media:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=chcunningham@chromium.org

Committed: https://crrev.com/e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b
Cr-Commit-Position: refs/heads/master@{#416946}

[fdoray, 2016-09-06 20:27:35]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:28:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:51:23]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-09-06 21:55:19]

PTAL

[chcunningham, 2016-09-06 22:49:50]

https://codereview.chromium.org/2317803002/diff/1/media/audio/android/audio_a...
File media/audio/android/audio_android_unittest.cc (right):

https://codereview.chromium.org/2317803002/diff/1/media/audio/android/audio_a...
media/audio/android/audio_android_unittest.cc:515: &count, num_callbacks,
loop()->task_runner(),
Do we still need this loop()? Could we instead remove it and simply use
MessageLoop::current()->task_runner()?

https://codereview.chromium.org/2317803002/diff/1/media/cast/test/utility/tap...
File media/cast/test/utility/tap_proxy.cc (right):

https://codereview.chromium.org/2317803002/diff/1/media/cast/test/utility/tap...
media/cast/test/utility/tap_proxy.cc:308: base::MessageLoopForIO message_loop;
Same question. Won't RunLoop().Run() lazy init a loop on the current thread for
us? Can we delete this one?

[fdoray, 2016-09-07 13:31:16]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 13:31:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-07 13:31:34]

PTAnL

https://codereview.chromium.org/2317803002/diff/1/media/audio/android/audio_a...
File media/audio/android/audio_android_unittest.cc (right):

https://codereview.chromium.org/2317803002/diff/1/media/audio/android/audio_a...
media/audio/android/audio_android_unittest.cc:515: &count, num_callbacks,
loop()->task_runner(),
On 2016/09/06 22:49:50, chcunningham wrote:
> Do we still need this loop()? Could we instead remove it and simply use
> MessageLoop::current()->task_runner()?

Done. base::ThreadTaskRunnerHandle::Get() returns the same thing as
MessageLoop::current()->task_runner() on a MessageLoop thread but also works in
base/task_scheduler.

https://codereview.chromium.org/2317803002/diff/1/media/cast/test/utility/tap...
File media/cast/test/utility/tap_proxy.cc (right):

https://codereview.chromium.org/2317803002/diff/1/media/cast/test/utility/tap...
media/cast/test/utility/tap_proxy.cc:308: base::MessageLoopForIO message_loop;
On 2016/09/06 22:49:50, chcunningham wrote:
> Same question. Won't RunLoop().Run() lazy init a loop on the current thread
for
> us? Can we delete this one?

A base::RunLoop needs to be instantiated within the scope of a MessageLoop. It
will run that MessageLoop.
https://cs.chromium.org/chromium/src/base/run_loop.cc?l=14

[commit-bot: I haz the power, 2016-09-07 15:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 15:22:45]

Dry run: This issue passed the CQ dry run.

[chcunningham, 2016-09-07 15:59:35]

lgtm

https://codereview.chromium.org/2317803002/diff/1/media/cast/test/utility/tap...
File media/cast/test/utility/tap_proxy.cc (right):

https://codereview.chromium.org/2317803002/diff/1/media/cast/test/utility/tap...
media/cast/test/utility/tap_proxy.cc:308: base::MessageLoopForIO message_loop;
Ah, sorry I saw that MessageLoop::current() used a lazy initializer, but I see
now that its just lazy constructing the TLS object and we still need to bind a
loop to that TLS object (ie construct the loop).

[fdoray, 2016-09-07 16:01:30]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-07 16:02:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:08:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 16:11:08]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods in media.

This CL (hopefully) removes all calls to these methods in media:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=chcunningham@chromium.org
==========

to

==========
Remove calls to deprecated MessageLoop methods in media.

This CL (hopefully) removes all calls to these methods in media:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=chcunningham@chromium.org

Committed: https://crrev.com/e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b
Cr-Commit-Position: refs/heads/master@{#416946}
==========

[commit-bot: I haz the power, 2016-09-07 16:11:09]

Patchset 2 (id:??) landed as
https://crrev.com/e74ea6f8bc4bf98b6a8d5e147a5e52de261d135b
Cr-Commit-Position: refs/heads/master@{#416946}