Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2317783003: Stage Intl.DateTimeFormat.formatToParts (Closed)

Created:
4 years, 3 months ago by jungshik at Google
Modified:
4 years, 3 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage Intl.DateTimeFormat.formatToParts Move it to HARMONY_STAGED bucket Spec discussion: https://github.com/tc39/ecma402/issues/30 It's in stage 4 and Firefox has already implemented it. BUG=v8:5244 TEST=intl/date-format/date-format-to-parts.js TEST=test262/intl402/DateTimeFormat/prototype/formatToParts/* Committed: https://crrev.com/147c810cc710c3e804c4a90963d08e1aff4aeef3 Cr-Commit-Position: refs/heads/master@{#39258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M src/flag-definitions.h View 3 chunks +4 lines, -11 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jungshik at Google
Hi Dan, can you take a look?
4 years, 3 months ago (2016-09-06 23:55:05 UTC) #2
Dan Ehrenberg
lgtm
4 years, 3 months ago (2016-09-06 23:56:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317783003/1
4 years, 3 months ago (2016-09-07 16:47:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 17:16:56 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:17:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/147c810cc710c3e804c4a90963d08e1aff4aeef3
Cr-Commit-Position: refs/heads/master@{#39258}

Powered by Google App Engine
This is Rietveld 408576698