[Sensors] Implementation of the Generic Sensor API

[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework, i.e. implementation of 'Sensor' and 'SensorReading' classes.

Also it introduces 'SensorPollingStrategy' interface that should provide different polling behaviour depending on
the sensor reporting mode (implementation will be added in the following CLs).

Specification: https://w3c.github.io/sensors

BUG=606766
Committed: https://crrev.com/9f86cf248d11f5d6b9de962c75821b952622b8c8
Cr-Commit-Position: refs/heads/master@{#417200}

[Mikhail, 2016-09-06 17:25:13]

Description was changed from

==========
[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework,
i.e. implementation of 'Sensor' and 'SensorReading' classes.

Specification: https://w3c.github.io/sensors

BUG=606766
==========

to

==========
[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework,
i.e. implementation of 'Sensor' and 'SensorReading' classes.

Specification: https://w3c.github.io/sensors

BUG=606766
==========

[Mikhail, 2016-09-06 17:25:13]

mikhail.pozdnyakov@intel.com changed reviewers:
+ haraken@chromium.org, timvolodine@chromium.org

[Mikhail, 2016-09-07 11:13:46]

Patchset #2 (id:20001) has been deleted

[Mikhail, 2016-09-07 13:02:39]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 13:02:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 13:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 13:04:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Mikhail, 2016-09-07 13:09:34]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 13:09:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-09-07 13:53:06]

PTAL

[commit-bot: I haz the power, 2016-09-07 14:29:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 14:29:59]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-09-07 15:53:44]

In terms of implementation, LGTM.

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/sensor/Sensor.h (right):

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/sensor/Sensor.h:29: , public ActiveDOMObject

Change this to ContextLifecycleObserver.

You're not overriding resume/suspend, so you won't need ActiveDOMObject.

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/sensor/Sensor.h:77: void stop() override;

Then this method can be contextDestroyed(); i.e., you can avoid adding two
stop() methods to this class.

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/sensor/SensorReading.cpp (right):

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/sensor/SensorReading.cpp:32: if (!performance)

This should be never null.

[timvolodine, 2016-09-07 17:04:10]

lgtm % comment below and assuming comments from the original large patch
https://codereview.chromium.org/2121313002/ still applied.

nit: you could say something about the SensorPollingStrategy base class in the
description for completeness sake as well.

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/sensor/Sensor.h (right):

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/sensor/Sensor.h:64: ~Sensor();
virtual or override

nit: also, I think usually before "DECLARE_VIRTUAL_TRACE" somewhere towards the
top

[Mikhail, 2016-09-07 18:29:24]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 18:29:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-09-07 18:36:26]

Description was changed from

==========
[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework,
i.e. implementation of 'Sensor' and 'SensorReading' classes.

Specification: https://w3c.github.io/sensors

BUG=606766
==========

to

==========
[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework,
i.e. implementation of 'Sensor' and 'SensorReading' classes.

Also it introduces 'SensorPollingStrategy' interface that should provide
different polling behaviour depending on
the sensor reporting mode (implementation will be added in the following CLs).

Specification: https://w3c.github.io/sensors

BUG=606766
==========

[Mikhail, 2016-09-07 18:37:23]

Thanks for review!

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/sensor/Sensor.h (right):

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/sensor/Sensor.h:29: , public ActiveDOMObject
On 2016/09/07 15:53:43, haraken wrote:
> 
> Change this to ContextLifecycleObserver.
> 
> You're not overriding resume/suspend, so you won't need ActiveDOMObject.

Done.

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/sensor/Sensor.h:64: ~Sensor();
On 2016/09/07 17:04:10, timvolodine wrote:
> virtual or override
> 
> nit: also, I think usually before "DECLARE_VIRTUAL_TRACE" somewhere towards
the
> top

Done.

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/sensor/Sensor.h:77: void stop() override;
On 2016/09/07 15:53:43, haraken wrote:
> 
> Then this method can be contextDestroyed(); i.e., you can avoid adding two
> stop() methods to this class.

Done.

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/sensor/SensorReading.cpp (right):

https://codereview.chromium.org/2317743002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/sensor/SensorReading.cpp:32: if (!performance)
On 2016/09/07 15:53:43, haraken wrote:
> 
> This should be never null.

Done.

[commit-bot: I haz the power, 2016-09-07 20:53:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:53:23]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-09-07 23:12:30]

LGTM

[Mikhail, 2016-09-08 05:22:27]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-09-08 05:22:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2317743002/#ps60001
(title: "Comments from Tim and haraken")

[commit-bot: I haz the power, 2016-09-08 05:22:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 05:49:28]

Description was changed from

==========
[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework,
i.e. implementation of 'Sensor' and 'SensorReading' classes.

Also it introduces 'SensorPollingStrategy' interface that should provide
different polling behaviour depending on
the sensor reporting mode (implementation will be added in the following CLs).

Specification: https://w3c.github.io/sensors

BUG=606766
==========

to

==========
[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework,
i.e. implementation of 'Sensor' and 'SensorReading' classes.

Also it introduces 'SensorPollingStrategy' interface that should provide
different polling behaviour depending on
the sensor reporting mode (implementation will be added in the following CLs).

Specification: https://w3c.github.io/sensors

BUG=606766
==========

[commit-bot: I haz the power, 2016-09-08 05:49:29]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-08 05:51:22]

Description was changed from

==========
[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework,
i.e. implementation of 'Sensor' and 'SensorReading' classes.

Also it introduces 'SensorPollingStrategy' interface that should provide
different polling behaviour depending on
the sensor reporting mode (implementation will be added in the following CLs).

Specification: https://w3c.github.io/sensors

BUG=606766
==========

to

==========
[Sensors] Implementation of the Generic Sensor API

This patch contains blink-side infrastructure of the Generic Sensors Framework,
i.e. implementation of 'Sensor' and 'SensorReading' classes.

Also it introduces 'SensorPollingStrategy' interface that should provide
different polling behaviour depending on
the sensor reporting mode (implementation will be added in the following CLs).

Specification: https://w3c.github.io/sensors

BUG=606766

Committed: https://crrev.com/9f86cf248d11f5d6b9de962c75821b952622b8c8
Cr-Commit-Position: refs/heads/master@{#417200}
==========

[commit-bot: I haz the power, 2016-09-08 05:51:23]

Patchset 3 (id:??) landed as
https://crrev.com/9f86cf248d11f5d6b9de962c75821b952622b8c8
Cr-Commit-Position: refs/heads/master@{#417200}