Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2317723003: [Offline Pages] Removes the deprecated IsOfflinePages synthetic flag since no uses of it remain. (Closed)

Created:
4 years, 3 months ago by dougarnett
Modified:
4 years, 3 months ago
Reviewers:
fgorski, dewittj
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Removes the deprecated IsOfflinePages synthetic flag since no uses of it remain. BUG=639354 Committed: https://crrev.com/d21dd99d2dcc8a9105066da74bf1ddffcd7faa3a Cr-Commit-Position: refs/heads/master@{#416967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java View 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/offline_pages/offline_page_feature.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/offline_pages/offline_page_feature.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dougarnett
4 years, 3 months ago (2016-09-06 18:00:33 UTC) #4
fgorski
lgtm Cool: diffs are red and bots are green (mostly as of now).
4 years, 3 months ago (2016-09-06 18:08:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317723003/1
4 years, 3 months ago (2016-09-07 16:47:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 16:51:29 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:52:58 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d21dd99d2dcc8a9105066da74bf1ddffcd7faa3a
Cr-Commit-Position: refs/heads/master@{#416967}

Powered by Google App Engine
This is Rietveld 408576698