Subzero, MIPS32: Introduction of genTargetHelperCallFor

Subzero, MIPS32: Introduction of genTargetHelperCallFor

genTargetHelperCallFor provides framework for calling Subzero
runtime functions. This patch implements calls and tests for
some of the available functions, but not all. Current
lowerCall implementation does not allow more (Handling of FP
return values is missing).

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b85cde16ed42ab738e1cfcf0f39b06eae43fec99

[obucinac, 2016-09-06 19:46:15]

Description was changed from

==========
Subzero, MIPS32: Introduction of genTargetHelperCallFor

genTargetHelperCallFor provides framework for calling Subzero
runtime functions. This patch implements calls and tests for some
of available functions, but not all. Current lowerCall
implementation does not allow more (Handling of FP return values
is missing).

BUG=
==========

to

==========
Subzero, MIPS32: Introduction of genTargetHelperCallFor

genTargetHelperCallFor provides framework for calling Subzero
runtime functions. This patch implements calls and tests for
some of the available functions, but not all. Current
lowerCall implementation does not allow more (Handling of FP
return values is missing).
==========

[obucinac, 2016-09-06 19:46:15]

obucinac@gmail.com changed reviewers:
+ eholk@chromium.org, jaydeep.patil@imgtec.com, jpp@chromium.org,
kschimpf@google.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2016-09-07 04:17:31]

https://codereview.chromium.org/2317653004/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2317653004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:347: //  if (Op != InstArithmetic::Frem) {
Could you leave this code uncommented?  Maybe prepend an llvm_unreachable call
that the frem implementation is TODO.

https://codereview.chromium.org/2317653004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:572: Ctx->getGlobalString("__aeabi_read_tp"))
Pretty sure this helper function is ARM-only.

The non-sfi people have moved on from wanting to use Subzero, so I think it
would be enough to assert(SandboxingType!=ST_Nonsfi) here instead.

[obucinac, 2016-09-07 15:08:55]

https://codereview.chromium.org/2317653004/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2317653004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:347: //  if (Op != InstArithmetic::Frem) {
On 2016/09/07 04:17:31, stichnot wrote:
> Could you leave this code uncommented?  Maybe prepend an llvm_unreachable call
> that the frem implementation is TODO.

I decided to remove it, until we fix the lowerCall.

https://codereview.chromium.org/2317653004/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:572: Ctx->getGlobalString("__aeabi_read_tp"))
On 2016/09/07 04:17:31, stichnot wrote:
> Pretty sure this helper function is ARM-only.
> 
> The non-sfi people have moved on from wanting to use Subzero, so I think it
> would be enough to assert(SandboxingType!=ST_Nonsfi) here instead.

Done.

[Jim Stichnoth, 2016-09-09 16:37:52]

lgtm

[Jim Stichnoth, 2016-09-09 16:39:54]

Description was changed from

==========
Subzero, MIPS32: Introduction of genTargetHelperCallFor

genTargetHelperCallFor provides framework for calling Subzero
runtime functions. This patch implements calls and tests for
some of the available functions, but not all. Current
lowerCall implementation does not allow more (Handling of FP
return values is missing).
==========

to

==========
Subzero, MIPS32: Introduction of genTargetHelperCallFor

genTargetHelperCallFor provides framework for calling Subzero
runtime functions. This patch implements calls and tests for
some of the available functions, but not all. Current
lowerCall implementation does not allow more (Handling of FP
return values is missing).

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-09-09 16:39:55]

Committed patchset #3 (id:40001) manually as
b85cde16ed42ab738e1cfcf0f39b06eae43fec99 (presubmit successful).