Support sideloaded fonts via command line option for blink layout_tests

content/renderer/renderer_main_platform_delegate_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_main_platform_delegate.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
@@ skipping 48 matching lines @@
   DWriteCreateFactoryProc dwrite_create_factory_proc =
       reinterpret_cast<DWriteCreateFactoryProc>(
           GetProcAddress(LoadLibraryW(L"dwrite.dll"), "DWriteCreateFactory"));
   CHECK(dwrite_create_factory_proc);
   CHECK(SUCCEEDED(
       dwrite_create_factory_proc(DWRITE_FACTORY_TYPE_ISOLATED,
                                  __uuidof(IDWriteFactory),
                                  reinterpret_cast<IUnknown**>(factory))));
 }
 
+void WarmupFontPaint(SkTypeface* typeface) {
+  SkPaint paint_warmup;
+  paint_warmup.setTypeface(typeface);
+  wchar_t glyph = L'S';
+  paint_warmup.measureText(&glyph, 2);
+}
+
+// DirectWrite only has access to %WINDIR%\Fonts by default. For developer
+// side-loading, support kRegisterFontFiles to allow access to additional fonts.
+void RegisterSideloadedTypefaces(SkFontMgr* fontmgr) {
+  std::vector<std::string> files;
+  if (GetSideloadFontFiles(&files)) {
+    for (std::vector<std::string>::const_iterator i(files.begin());
+         i != files.end();
+         ++i) {
+      SkTypeface* typeface = fontmgr->createFromFile(i->c_str());
+      WarmupFontPaint(typeface);
+      blink::WebFontRendering::addSideloadedFontForTesting(typeface);
+    }
+  }
+}
+
 void WarmupDirectWrite() {
   // The objects used here are intentionally not freed as we want the Skia
   // code to use these objects after warmup.
   IDWriteFactory* factory;
   CreateDirectWriteFactory(&factory);
   blink::WebFontRendering::setDirectWriteFactory(factory);
   SkFontMgr* fontmgr = SkFontMgr_New_DirectWrite(factory);
   SkTypeface* typeface = fontmgr->legacyCreateTypeface("Times New Roman", 0);
-  SkPaint paint_warmup;
-  paint_warmup.setTypeface(typeface);
-  wchar_t glyph = L'S';
-  paint_warmup.measureText(&glyph, 2);
+  WarmupFontPaint(typeface);
+
+  // Register auxiliary non-system installed fonts. This is primarily for
+  // Blink layout tests.

[jam, 2014/04/14 05:40:02]

since this is only for layout tests, can you do this entire change in
content/shell? i.e. content embedders can modify the sandbox policy in
ContentBrowserClient::PreSpawnRenderer

[scottmg, 2014/04/14 15:48:58]

It's mostly for Blink but is useful for testing to have it in Chrome. There's
also font managers which could use this, ref:
https://codereview.chromium.org/209163002#msg7

OTOH, it's nicer to keep it out of Chrome. Justin, any opinions either way?

[jschuh, 2014/04/14 15:58:51]

I'm inclined to say keep it in Chrome just to make testing easier, but I don't
feel strongly either way.

[jam, 2014/04/14 16:20:59]

note that testing could still be done using content_shell.

i prefer we don't put it outside content/shell for now, until we have a need
otherwise.

+  RegisterSideloadedTypefaces(fontmgr);
 }
 
 }  // namespace
 
 RendererMainPlatformDelegate::RendererMainPlatformDelegate(
     const MainFunctionParams& parameters)
         : parameters_(parameters),
           sandbox_test_module_(NULL) {
 }
 
@@ skipping 86 matching lines @@
     if (run_security_tests) {
       int test_count = 0;
       DVLOG(1) << "Running renderer security tests";
       BOOL result = run_security_tests(&test_count);
       CHECK(result) << "Test number " << test_count << " has failed.";
     }
   }
 }
 
 }  // namespace content