Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 2317623003: [turbofan] Handle ObjectIsReceiver in escape analysis. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Handle ObjectIsReceiver in escape analysis. This adds handling of {IrOpcode::kObjectIsReceiver} nodes to the escape status analysis. Such uses are treated as escaping for now until we add dedicated handling to the escape analysis reducer. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-631027 BUG=chromium:631027 Committed: https://crrev.com/553d5049235d0ecef07ddc29661501cc670cccd8 Cr-Commit-Position: refs/heads/master@{#39205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-631027.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-06 11:32:14 UTC) #3
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-06 11:32:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317623003/1
4 years, 3 months ago (2016-09-06 11:56:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 11:58:48 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 11:59:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/553d5049235d0ecef07ddc29661501cc670cccd8
Cr-Commit-Position: refs/heads/master@{#39205}

Powered by Google App Engine
This is Rietveld 408576698