Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/fetch/RawResource.cpp

Issue 2317613002: Add NEVER_INLINE to RawResourceClientStateChecker to show it in stack traces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/RawResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/RawResource.cpp b/third_party/WebKit/Source/core/fetch/RawResource.cpp
index 4aec26459642a659fa5082df00c08e86779320d9..129ffa734e10d3640e44e02261d1b02e2569c960 100644
--- a/third_party/WebKit/Source/core/fetch/RawResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/RawResource.cpp
@@ -269,35 +269,35 @@ RawResourceClientStateChecker::~RawResourceClientStateChecker()
{
}
-void RawResourceClientStateChecker::willAddClient()
+NEVER_INLINE void RawResourceClientStateChecker::willAddClient()
{
SECURITY_CHECK(m_state == NotAddedAsClient);
m_state = Started;
}
-void RawResourceClientStateChecker::willRemoveClient()
+NEVER_INLINE void RawResourceClientStateChecker::willRemoveClient()
{
SECURITY_CHECK(m_state != NotAddedAsClient);
m_state = NotAddedAsClient;
}
-void RawResourceClientStateChecker::redirectReceived()
+NEVER_INLINE void RawResourceClientStateChecker::redirectReceived()
{
SECURITY_CHECK(m_state == Started);
}
-void RawResourceClientStateChecker::redirectBlocked()
+NEVER_INLINE void RawResourceClientStateChecker::redirectBlocked()
{
SECURITY_CHECK(m_state == Started);
m_state = RedirectBlocked;
}
-void RawResourceClientStateChecker::dataSent()
+NEVER_INLINE void RawResourceClientStateChecker::dataSent()
{
SECURITY_CHECK(m_state == Started);
}
-void RawResourceClientStateChecker::responseReceived()
+NEVER_INLINE void RawResourceClientStateChecker::responseReceived()
{
// TODO(hiroshige): Temporarily we use DCHECK() here instead of CHECK(),
// due to crbug.com/640960.
@@ -305,25 +305,25 @@ void RawResourceClientStateChecker::responseReceived()
m_state = ResponseReceived;
}
-void RawResourceClientStateChecker::setSerializedCachedMetadata()
+NEVER_INLINE void RawResourceClientStateChecker::setSerializedCachedMetadata()
{
SECURITY_CHECK(m_state == ResponseReceived);
m_state = SetSerializedCachedMetadata;
}
-void RawResourceClientStateChecker::dataReceived()
+NEVER_INLINE void RawResourceClientStateChecker::dataReceived()
{
SECURITY_CHECK(m_state == ResponseReceived || m_state == SetSerializedCachedMetadata || m_state == DataReceived);
m_state = DataReceived;
}
-void RawResourceClientStateChecker::dataDownloaded()
+NEVER_INLINE void RawResourceClientStateChecker::dataDownloaded()
{
SECURITY_CHECK(m_state == ResponseReceived || m_state == SetSerializedCachedMetadata || m_state == DataDownloaded);
m_state = DataDownloaded;
}
-void RawResourceClientStateChecker::notifyFinished(Resource* resource)
+NEVER_INLINE void RawResourceClientStateChecker::notifyFinished(Resource* resource)
{
SECURITY_CHECK(m_state != NotAddedAsClient);
SECURITY_CHECK(m_state != NotifyFinished);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698