Create proper wrapper scripts to decouple from swarm_client.

scripts/master/factory/swarm_commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set of utilities to add commands to a buildbot factory.
 
 This is based on commands.py and adds swarm-specific commands."""
 
 from buildbot.process.properties import WithProperties
 from buildbot.steps import shell, source
@@ skipping 71 matching lines @@
     'swarm_hashes' is already related to GetSwarmTests().
     """
     # Only used for pass gtest filters specified by the user via 'testfilter'.
     swarm_tests = commands.GetSwarmTests(self)
     # The 'swarm_hashes' build property has been set by the
     # CalculateIsolatedSha1s build step. It will have all the steps that can be
     # triggered. This implicitly takes account 'testfilter'.
     swarm_tests_hash_mapping = commands.GetProp(self, 'swarm_hashes', {})
 
     command = self.command[:]
+
+    # Determine the priority. (Lower the more important) There's 3 levels:
+    # - Continuous Integration: 10
+    # - CQ Try Jobs:            50
+    # - Try Jobs:               90
+    # Default priority is      100
+    # So determine the priority.
+    priority = 10
+    requester = commands.GetProp(self, 'requester', None)
+    if requester == 'commit-bot@chromium.org':
+      # A CQ job.
+      priority = 50
+    elif requester or commands.GetProp(self, 'testfilter', None):
+      # A try job.
+      priority = 90
+    command.extend(('--priority', str(priority)))

[Isaac (away), 2013/08/14 20:23:18]

Is there a way to move this logic to a slaves script?  It looks OK but we might
want to tweak it without needed a ts restart.

I'm going to pull in robbie to get a second opinion.

+
     for swarm_test in self.tests:
       if swarm_tests_hash_mapping.get(swarm_test.test_name):
         command.extend(
             [
               '--run_from_hash',
               swarm_tests_hash_mapping[swarm_test.test_name],
               swarm_test.test_name,
               '%d' % swarm_test.shards,
               # '*' is a special value to mean no filter. This is used so '' is
               # not used, as '' may be misinterpreted by the shell, especially
@@ skipping 122 matching lines @@
 
     command = [self._python, script_path, '--drive', drive,
                '--network_path', network_path]
 
     self._factory.addStep(
         shell.ShellCommand,
         name='setup_windows_network_storage',
         description='setup_windows_network_storage',
         descriptionDone='setup_windows_network_storage',
         command=command)